Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: update .rejectedWith with new .checkError #235

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] feat: update .rejectedWith with new .checkError #235

wants to merge 1 commit into from

Conversation

meeber
Copy link
Contributor

@meeber meeber commented Nov 26, 2017

BREAKING CHANGE: Update failed assertion messages for .rejectedWith
for simplicity, consistency, and correctness. Update .rejectedWith
to only perform criteria matching on Error instances.

This PR is a WIP. This PR is demonstrating breaking changes in chai and check-error that aren't released yet (and may not be released if maintainers don't like it). If these changes are released, it'll be done with a major version bump. The purpose of these changes is to drastically simplify the error-checking logic (which in turn simplifies rejectedWith). It also makes failed assertion messages related to errors more consistent across Chai.

Related: chaijs/chai#1021 and chaijs/check-error#18

BREAKING CHANGE: Update failed assertion messages for `.rejectedWith`
for simplicity, consistency, and correctness. Update `.rejectedWith`
to only perform criteria matching on `Error` instances.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant