Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #214, request defaults not set when using Agent. #215

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bkuker
Copy link

@bkuker bkuker commented Jun 29, 2018

No description provided.

@bkuker
Copy link
Author

bkuker commented Jul 25, 2018

Is there anything I can do to help out with this? I can make an intern write some tests, or stand on his head, or whatever.

@keithamus
Copy link
Member

This looks great! But yes, let's get some tests in here before merging please!

@bkuker
Copy link
Author

bkuker commented Sep 5, 2018

I think the tests on travis-ci are timing out randomly? :-/

@austince
Copy link
Contributor

austince commented Sep 5, 2018

I've tried re-running this and can confirm that it never passes on Travis's latest node and latest LTS images, yet the tests pass locally with those versions.

Trying to figure out if this is a travis problem 🤷‍♂️.

@bkuker
Copy link
Author

bkuker commented Sep 17, 2018

Odd, now the tests are actually failing, not just timing out. I guess that is better, we'll try to sort it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants