Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(registry): added max committed gas limit per validator #251

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

merklefruit
Copy link
Collaborator

  • added missing docs
  • removed Validator.authorizedCollateralProvider because it wasn't used
  • added Validator.maxCommittedGasLimit

Note: this PR adds this value to the registry + middleware contracts, but it doesn't update the Challenger or any of the off-chain components reading the registry such as the RPC. That will be done in separate PRs.

@merklefruit merklefruit added the C: smart-contracts Component: smart contracts label Oct 1, 2024
@merklefruit merklefruit requested a review from mempirate October 1, 2024 09:36
@merklefruit merklefruit self-assigned this Oct 1, 2024
Copy link
Contributor

@mempirate mempirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@merklefruit merklefruit merged commit ade1063 into nico/feat/commitment-registry Oct 2, 2024
4 checks passed
@merklefruit merklefruit deleted the nico/feat/max-gas-limit branch October 2, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: smart-contracts Component: smart contracts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants