Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add delegations cli #293

Merged
merged 23 commits into from
Oct 16, 2024
Merged

feat: add delegations cli #293

merged 23 commits into from
Oct 16, 2024

Conversation

namn-grg
Copy link
Contributor

@namn-grg namn-grg commented Oct 15, 2024 •
edited
Loading

Overview

  • Added a simple cli tool to generate signed delegation message.
  • The private key for signing the message can be read from :

Meta

closes #286

related PR #292

@namn-grg namn-grg force-pushed the naman/feat/delegations-cli branch from cda0514 to 03d1c96 Compare October 15, 2024 06:51
@merklefruit merklefruit added the T: feature Type: Feature label Oct 15, 2024
@merklefruit merklefruit added this to the v0.3: Holesky 1 milestone Oct 15, 2024
thedevbirb
thedevbirb requested changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@thedevbirb thedevbirb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Can you also add some tests? You can take a look at tempfile crate if you need to create temporary files and drop them when the test end.

bolt-delegations-cli/.gitignore Outdated Show resolved Hide resolved
bolt-delegations-cli/README.md Outdated Show resolved Hide resolved
bolt-delegations-cli/README.md Outdated Show resolved Hide resolved
bolt-delegations-cli/src/config.rs Outdated Show resolved Hide resolved
bolt-delegations-cli/src/main.rs Outdated Show resolved Hide resolved
bolt-delegations-cli/src/types.rs Outdated Show resolved Hide resolved
thedevbirb
thedevbirb approved these changes Oct 15, 2024
View reviewed changes
bolt-delegations-cli/README.md Outdated Show resolved Hide resolved
thedevbirb
thedevbirb requested changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@thedevbirb thedevbirb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things!

bolt-delegations-cli/src/main.rs Outdated Show resolved Hide resolved
bolt-delegations-cli/src/main.rs Show resolved Hide resolved
bolt-delegations-cli/src/main.rs Outdated Show resolved Hide resolved
bolt-delegations-cli/src/types.rs Show resolved Hide resolved
@merklefruit merklefruit merged commit 0fd6b97 into unstable Oct 16, 2024
2 checks passed
@merklefruit merklefruit deleted the naman/feat/delegations-cli branch October 16, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merklefruit merklefruit merklefruit left review comments

@thedevbirb thedevbirb thedevbirb approved these changes

@mempirate mempirate Awaiting requested review from mempirate

Assignees

@namn-grg namn-grg

Labels
T: feature Type: Feature
Projects
None yet
Milestone
v0.3: Holesky 1
Development

Successfully merging this pull request may close these issues.

Tool for signing a delegation message
3 participants
@namn-grg @merklefruit @thedevbirb