Test: add/improve handover tests (#3959)

* refactor: key verification callback registered internally

* feat: more precise comparison

* feat: differentiate between candidates and authorities in handover tests

* chore: deduplicate do_full_key_rotation in tests

* test: update test to do what is says

* test: check key verification request parameters

* feat: use log_or_panic

* test: all candidates participate in handover

* test: add missing vault rotator status checks

* chore: fix clippy

* test: fix incorrect assert

state-chain/pallets/cf-broadcast/src/lib.rs

@@ -354,7 +354,7 @@ pub mod pallet {
 
 				let mut retries = BroadcastRetryQueue::<T, I>::take();
 
-				if retries.len() >= num_retries_that_fit {
+				if retries.len() > num_retries_that_fit {
 					BroadcastRetryQueue::<T, I>::put(retries.split_off(num_retries_that_fit));
 				}
 

state-chain/pallets/cf-threshold-signature/Cargo.toml

@@ -17,6 +17,7 @@ cf-chains = { path = '../../chains', default-features = false }
 cf-primitives = { path = '../../primitives', default-features = false }
 cf-runtime-upgrade-utilities = { path = '../../runtime-upgrade-utilities', default-features = false }
 cf-traits = { path = '../../traits', default-features = false }
+cf-runtime-utilities = { path = '../../runtime-utilities', default-features = false}
 
 log = { version = '0.4.16', default-features = false }
 

state-chain/pallets/cf-threshold-signature/src/lib.rs

@@ -25,6 +25,7 @@ use cf_traits::{
 	EpochKey, KeyProvider, ThresholdSignerNomination,
 };
 
+use cf_runtime_utilities::log_or_panic;
 use frame_support::{
 	dispatch::UnfilteredDispatchable,
 	ensure,
@@ -823,11 +824,19 @@ where
 		participants: BTreeSet<Self::ValidatorId>,
 		key: <T::TargetChainCrypto as ChainCrypto>::AggKey,
 		epoch_index: EpochIndex,
+		on_signature_ready: impl FnOnce(cf_primitives::ThresholdSignatureRequestId) -> Self::Callback,
 	) -> RequestId {
-		Self::inner_request_signature(
+		let request_id = Self::inner_request_signature(
 			payload,
 			RequestType::KeygenVerification { key, participants, epoch_index },
-		)
+		);
+
+		if Self::register_callback(request_id, on_signature_ready(request_id)).is_err() {
+			// We should never fail to register a callback for a request that we just created.
+			log_or_panic!("Failed to register callback for request {}", request_id);
+		}
+
+		request_id
 	}
 
 	fn register_callback(

state-chain/pallets/cf-threshold-signature/src/tests.rs

@@ -254,11 +254,8 @@ fn keygen_verification_ceremony_calls_callback_on_failure() {
 				NOMINEES.into_iter().collect(),
 				key,
 				0,
+				MockCallback::new,
 			);
-			assert_ok!(EthereumThresholdSigner::register_callback(
-				request_id,
-				MockCallback::new(request_id)
-			));
 
 			// Callback was just registered, so cannot have been called.
 			assert!(!MockCallback::has_executed(request_id));
@@ -498,6 +495,7 @@ mod unsigned_validation {
 				participants,
 				CUSTOM_AGG_KEY,
 				0,
+				MockCallback::new,
 			);
 			let ceremony_id = MockCeremonyIdProvider::get();
 

state-chain/pallets/cf-vaults/src/lib.rs

@@ -893,16 +893,9 @@ impl<T: Config<I>, I: 'static> Pallet<T, I> {
 			participants,
 			new_agg_key,
 			next_epoch,
+			signature_callback_fn,
 		);
 
-		T::ThresholdSigner::register_callback(request_id, signature_callback_fn(request_id))
-			.unwrap_or_else(|e| {
-				log::error!(
-				"Unable to register threshold signature callback. This should not be possible. Error: '{:?}'",
-				e.into()
-			);
-			});
-
 		PendingVaultRotation::<T, I>::put(status_to_set);
 
 		request_id