fix: remove existential deposit (#4243)

state-chain/cf-integration-tests/src/network.rs

@@ -128,7 +128,6 @@ impl Cli {
 	}
 
 	pub fn register_as_validator(account: &NodeId) {
-		System::inc_providers(account);
 		assert_ok!(<AccountRoles as AccountRoleRegistry<Runtime>>::register_account_role(
 			account,
 			AccountRole::Validator

state-chain/pallets/cf-emissions/src/mock.rs

@@ -76,10 +76,6 @@ impl system::Config for Test {
 impl_mock_chainflip!(Test);
 impl_mock_callback!(RuntimeOrigin);
 
-parameter_types! {
-	pub const ExistentialDeposit: u128 = 10;
-}
-
 parameter_types! {
 	pub const BlocksPerDay: u64 = 14400;
 }
@@ -94,7 +90,6 @@ impl_mock_waived_fees!(AccountId, RuntimeCall);
 impl pallet_cf_flip::Config for Test {
 	type RuntimeEvent = RuntimeEvent;
 	type Balance = u128;
-	type ExistentialDeposit = ExistentialDeposit;
 	type BlocksPerDay = BlocksPerDay;
 	type OnAccountFunded = MockOnAccountFunded;
 	type WeightInfo = ();

state-chain/pallets/cf-flip/src/lib.rs

@@ -21,7 +21,7 @@ pub use on_charge_transaction::FlipTransactionPayment;
 
 use frame_support::{
 	ensure,
-	traits::{Get, HandleLifetime, Hooks, Imbalance, OnKilledAccount, SignedImbalance},
+	traits::{Get, Imbalance, OnKilledAccount, SignedImbalance},
 };
 
 use codec::{Decode, Encode, MaxEncodedLen};
@@ -62,10 +62,6 @@ pub mod pallet {
 			+ Debug
 			+ From<u128>;
 
-		/// The minimum amount required to keep an account open.
-		#[pallet::constant]
-		type ExistentialDeposit: Get<Self::Balance>;
-
 		/// Blocks per day.
 		#[pallet::constant]
 		type BlocksPerDay: Get<BlockNumberFor<Self>>;
@@ -149,32 +145,6 @@ pub mod pallet {
 		NoPendingRedemptionForThisID,
 	}
 
-	#[pallet::hooks]
-	impl<T: Config> Hooks<BlockNumberFor<T>> for Pallet<T> {
-		/// Reap any accounts that are below `T::ExistentialDeposit`, and burn the dust.
-		fn on_idle(_block_number: BlockNumberFor<T>, remaining_weight: Weight) -> Weight {
-			let max_accounts_to_reap = remaining_weight
-				.ref_time()
-				.checked_div(T::WeightInfo::reap_one_account().ref_time())
-				.unwrap_or_default();
-			if max_accounts_to_reap == 0 {
-				return Weight::zero()
-			}
-
-			let mut number_of_accounts_reaped = 0u64;
-			Account::<T>::iter()
-				.filter(|(_account_id, flip_account)| {
-					flip_account.total() < T::ExistentialDeposit::get()
-				})
-				.take(max_accounts_to_reap as usize)
-				.for_each(|(account_id, _flip_account)| {
-					let _reap_result = frame_system::Provider::<T>::killed(&account_id);
-					number_of_accounts_reaped += 1u64;
-				});
-			T::WeightInfo::reap_one_account().saturating_mul(number_of_accounts_reaped)
-		}
-	}
-
 	#[pallet::call]
 	impl<T: Config> Pallet<T> {
 		/// Set the PER BLOCK slashing rate.

state-chain/pallets/cf-flip/src/mock.rs

@@ -62,10 +62,6 @@ impl frame_system::Config for Test {
 
 impl_mock_chainflip!(Test);
 
-parameter_types! {
-	pub const ExistentialDeposit: FlipBalance = 10;
-}
-
 parameter_types! {
 	pub const BlocksPerDay: u64 = 14400;
 }
@@ -76,7 +72,6 @@ impl_mock_waived_fees!(AccountId, RuntimeCall);
 impl pallet_cf_flip::Config for Test {
 	type RuntimeEvent = RuntimeEvent;
 	type Balance = FlipBalance;
-	type ExistentialDeposit = ExistentialDeposit;
 	type BlocksPerDay = BlocksPerDay;
 	type OnAccountFunded = MockOnAccountFunded;
 	type WeightInfo = ();

state-chain/pallets/cf-flip/src/tests.rs

@@ -2,15 +2,14 @@
 
 use super::*;
 use crate::{
-	mock::*, Account, Bonder, Error, FlipAccount, FlipIssuance, FlipSlasher, OffchainFunds,
-	Reserve, SlashingRate, TotalIssuance,
+	mock::*, Account, Bonder, Error, FlipIssuance, FlipSlasher, OffchainFunds, Reserve,
+	SlashingRate, TotalIssuance,
 };
 use cf_primitives::FlipBalance;
 use cf_traits::{AccountInfo, Bonding, Funding, Issuance, Slashing};
 use frame_support::{
 	assert_noop,
-	traits::{HandleLifetime, Hooks, Imbalance},
-	weights::Weight,
+	traits::{HandleLifetime, Imbalance},
 };
 use quickcheck::{Arbitrary, Gen, TestResult};
 use quickcheck_macros::quickcheck;
@@ -635,27 +634,3 @@ mod test_tx_payments {
 		});
 	}
 }
-
-#[test]
-fn can_reap_dust_account() {
-	new_test_ext().execute_with(|| {
-		Account::<Test>::insert(ALICE, FlipAccount { balance: 9, bond: 0 });
-		Account::<Test>::insert(BOB, FlipAccount { balance: 10, bond: 0 });
-		Account::<Test>::insert(CHARLIE, FlipAccount { balance: 11, bond: 0 });
-
-		// Dust accounts are reaped on_idle
-		Flip::on_idle(1, Weight::from_parts(1_000_000_000_000, 0));
-
-		assert!(!Account::<Test>::contains_key(ALICE));
-		assert_eq!(Account::<Test>::get(BOB), FlipAccount { balance: 10, bond: 0 });
-
-		assert_eq!(Account::<Test>::get(CHARLIE), FlipAccount { balance: 11, bond: 0 });
-		System::assert_has_event(RuntimeEvent::Flip(crate::Event::AccountReaped {
-			who: ALICE,
-			dust_burned: 9,
-		}));
-		System::assert_last_event(RuntimeEvent::System(frame_system::Event::KilledAccount {
-			account: ALICE,
-		}));
-	});
-}

state-chain/pallets/cf-funding/src/mock.rs

@@ -19,7 +19,6 @@ use std::time::Duration;
 
 // Use a realistic account id for compatibility with `RegisterRedemption`.
 type AccountId = AccountId32;
-type Balance = u128;
 type Block = frame_system::mocking::MockBlock<Test>;
 
 // Configure a mock runtime to test the pallet.
@@ -68,10 +67,6 @@ parameter_types! {
 	pub const CeremonyRetryDelay: BlockNumberFor<Test> = 1;
 }
 
-parameter_types! {
-	pub const ExistentialDeposit: Balance = 10;
-}
-
 parameter_types! {
 	pub const BlocksPerDay: u64 = 14400;
 }
@@ -82,7 +77,6 @@ impl_mock_waived_fees!(AccountId, RuntimeCall);
 impl pallet_cf_flip::Config for Test {
 	type RuntimeEvent = RuntimeEvent;
 	type Balance = u128;
-	type ExistentialDeposit = ExistentialDeposit;
 	type BlocksPerDay = BlocksPerDay;
 	type OnAccountFunded = MockOnAccountFunded;
 	type WeightInfo = ();

state-chain/pallets/cf-tokenholder-governance/src/mock.rs

@@ -62,10 +62,6 @@ impl system::Config for Test {
 impl_mock_chainflip!(Test);
 impl_mock_ensure_witnessed_for_origin!(RuntimeOrigin);
 
-parameter_types! {
-	pub const ExistentialDeposit: u128 = 10;
-}
-
 parameter_types! {
 	pub const BlocksPerDay: u64 = 14400;
 }

state-chain/runtime/src/lib.rs

@@ -506,7 +506,6 @@ impl pallet_authorship::Config for Runtime {
 impl pallet_cf_flip::Config for Runtime {
 	type RuntimeEvent = RuntimeEvent;
 	type Balance = FlipBalance;
-	type ExistentialDeposit = ConstU128<500>;
 	type BlocksPerDay = ConstU32<DAYS>;
 	type OnAccountFunded = pallet_cf_validator::UpdateBackupMapping<Self>;
 	type WeightInfo = pallet_cf_flip::weights::PalletWeight<Runtime>;