fix: take into account only active suspensions (#5359)

* keep into account only active suspensions

* filter out duplicates and properly count keygen suspensions

* addressed comments

---------

Co-authored-by: dandanlen <3168260+dandanlen@users.noreply.github.com>

state-chain/pallets/cf-validator/src/rotation_state.rs

@@ -6,7 +6,7 @@ use sp_std::collections::btree_set::BTreeSet;
 pub struct RotationState<Id, Amount> {
 	primary_candidates: Vec<Id>,
 	secondary_candidates: Vec<Id>,
-	banned: BTreeSet<Id>,
+	pub banned: BTreeSet<Id>,
 	pub bond: Amount,
 	pub new_epoch_index: EpochIndex,
 }

state-chain/runtime/src/lib.rs

@@ -2140,7 +2140,19 @@ impl_runtime_apis! {
 		}
 
 		fn cf_suspended_validators() -> Vec<(Offence, u32)> {
-			pallet_cf_reputation::Suspensions::<Runtime>::iter().map(|(key, elem)| (key, elem.len() as u32)).collect()
+			let suspended_for_keygen = match pallet_cf_validator::Pallet::<Runtime>::current_rotation_phase() {
+				pallet_cf_validator::RotationPhase::KeygensInProgress(rotation_state) |
+				pallet_cf_validator::RotationPhase::KeyHandoversInProgress(rotation_state) |
+				pallet_cf_validator::RotationPhase::ActivatingKeys(rotation_state) |
+				pallet_cf_validator::RotationPhase::NewKeysActivated(rotation_state) => { rotation_state.banned.len() as u32 },
+				_ => {0u32}
+			};
+			pallet_cf_reputation::Suspensions::<Runtime>::iter().map(|(key, _)| {
+				if key == pallet_cf_threshold_signature::PalletOffence::FailedKeygen.into() {
+					return (key, suspended_for_keygen);
+				}
+				(key, pallet_cf_reputation::Pallet::<Runtime>::validators_suspended_for(&[key]).len() as u32)
+			}).collect()
 		}
 		fn cf_epoch_state() -> EpochState {
 			let auction_params = Validator::auction_parameters();