-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LP API bouncer test #3806
LP API bouncer test #3806
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3806 +/- ##
=====================================
- Coverage 72% 72% -0%
=====================================
Files 366 366
Lines 57289 57340 +51
Branches 57289 57340 +51
=====================================
+ Hits 41357 41384 +27
- Misses 13844 13855 +11
- Partials 2088 2101 +13
... and 13 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
0622c67
to
75377ab
Compare
- cleanup other expected values
Going to delay this PR until it can be updated with the new LP API changes from #3886 |
bouncer/shared/lp_api_test.ts
Outdated
if (!isValidHexHash(await registerEwa)) { | ||
throw new Error(`Unexpected lp_registerLiquidityRefundAddress result`); | ||
} | ||
await observeRegisterEwaEvent; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also want to read LiquidityRefundAddress
from SC to ensure it has been set?
* tests: lp api bouncer test * refactor: split into smaller tests * chore: show balances in error * refactor: use asset instead of liquidity - cleanup other expected values * fix: provide eth and wait for finalization * refactor: address PR comments * refactor: trying to fix test running on CI * fix: check address type when depositing liquidity * fix: null channelMetadata * refactor: address PR comments * chore: don't run test concurrently * chore: run lp api test after others * refactor: update range and limit order commands * chore: rename Reg EWA -> Reg LRA * test: added get open swap channel test * refactor: address PR comments * refactor: run test in all concurrent
* tests: lp api bouncer test * refactor: split into smaller tests * chore: show balances in error * refactor: use asset instead of liquidity - cleanup other expected values * fix: provide eth and wait for finalization * refactor: address PR comments * refactor: trying to fix test running on CI * fix: check address type when depositing liquidity * fix: null channelMetadata * refactor: address PR comments * chore: don't run test concurrently * chore: run lp api test after others * refactor: update range and limit order commands * chore: rename Reg EWA -> Reg LRA * test: added get open swap channel test * refactor: address PR comments * refactor: run test in all concurrent
* tests: lp api bouncer test * refactor: split into smaller tests * chore: show balances in error * refactor: use asset instead of liquidity - cleanup other expected values * fix: provide eth and wait for finalization * refactor: address PR comments * refactor: trying to fix test running on CI * fix: check address type when depositing liquidity * fix: null channelMetadata * refactor: address PR comments * chore: don't run test concurrently * chore: run lp api test after others * refactor: update range and limit order commands * chore: rename Reg EWA -> Reg LRA * test: added get open swap channel test * refactor: address PR comments * refactor: run test in all concurrent
Pull Request
Closes: PRO-696
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Fetch
API to send the RPC's to the LP API serverall_concurrent_tests
, so i made it just run on its own.Notes
lp_registerAccount
command because the LP API Server account is already registered.Fetch
API has a warning:(node:36458) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time