-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Calculate ccm gas limit #3935
Merged
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
7db71ed
WIP:
syan095 f2cc9cb
Connected the calculated gas limit for CCM messages to Ethereum Trans…
syan095 00239ea
Merge remote-tracking branch 'origin/main' into feature/ccm-gas-limit
syan095 9e079b1
minor improvement to comments
syan095 68ad01a
Removed the default gas limit for CCM messages.
syan095 9e32512
Fixed minor typo
syan095 9a8fdae
Refactored so that the gas limit calculation is done when building Tr…
syan095 779563a
Merged latest from main.
syan095 3b335c4
Chore/mainnet ccm gaslimit test (#3887)
albert-llimos cab939c
chore: merge from main
albert-llimos af9a0fb
chore: add into() and small refactoring improvement
albert-llimos a61d85b
chore: add random gas consumption tests
albert-llimos 8da0758
fix: more generic gas limit, avoid panics
dandanlen 6941f3c
directly use Eip1559TransactionRequest
AlastairHolmes f59c32e
Renamed a parameter
syan095 048c7a6
Merge branch 'main' into feature/ccm-gas-limit
dandanlen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit confusing... looks like we downgraded the contracts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes I understand, but any follow-up tags can't be named perseverance-0.9-xyz as perseverance contracts have been deployed and will not changed. That would be even more confusing/wrong. So the best option to me seems going back to the normal tags and we launch mainnet with
v1.0.0
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about
0.10.0
?