feat: governance-pre-authorised-calls

[Janislav]

Pull Request

Closes: PRO-815

Checklist

Please conduct a thorough self-review before opening the PR.

• I am confident that the code works.
• I have updated documentation where appropriate.

Summary

Please include a succinct description of the purpose and content of the PR. What problem does it solve, and how? Link issues, discussions, other PRs, and anything else that will help the reviewer.

[linear]

PRO-815 Governance pre-authorised calls

We need to be able to "pre-authorise" governance calls so that the governance council can prepare a 'big red button' safe mode extrinsic that can be dispatched by any governance council member.

We can add a flag or option to the 'propose' extrinsic that modifies the behaviour such that the call will not be dispatched immediately but requires an explicit call to a new dispatch_whitelisted_call extrinsic in order to be executed.

We still want to default to the old behaviour whereby the call is dispatched as soon as it passes the voting threshold.

[codecov]

Codecov Report

Merging #3964 (41be65f) into main (a9a25eb) will decrease coverage by 0%.
The diff coverage is 52%.

@@          Coverage Diff           @@
##            main   #3964    +/-   ##
======================================
- Coverage     72%     72%    -0%     
======================================
  Files        366     366            
  Lines      57082   57211   +129     
  Branches   57082   57211   +129     
======================================
+ Hits       41210   41261    +51     
- Misses     13786   13849    +63     
- Partials    2086    2101    +15     

Files Changed	Coverage Δ
api/lib/src/lib.rs	33% <0%> (-<1%)	⬇️
state-chain/pallets/cf-governance/src/weights.rs	35% <34%> (-4%)	⬇️
state-chain/pallets/cf-governance/src/lib.rs	69% <73%> (-1%)	⬇️
...te-chain/pallets/cf-governance/src/benchmarking.rs	96% <100%> (+<1%)	⬆️
state-chain/pallets/cf-governance/src/tests.rs	100% <100%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[dandanlen]

Thanks Jan, looking good, just a couple of minor comments.

[dandanlen]

Let's use either whitelisted or pre-authorised, no need for two different words for the same thing.

[dandanlen]

I think an enum would make it clearer what the two options are (ie. automatic/implicit dispatch vs manual/explicit). Otherwise it's not immediately obvious that pre-authorised=false implies that the call will be automatically dispatched.

[dandanlen]

I made minor naming change + made it so that the Proposal doesn't need a default impl.