Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont reset vault state on handover retry #3988

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

dandanlen
Copy link
Collaborator

I think this should also go into the 0.9 release.

It's a change that is pending in PR #3909 (Thanks @syan095)

Not including this means that key handovers can't recover properly from failures.

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #3988 (773b03c) into release/0.9 (6fc28e6) will decrease coverage by 0%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           release/0.9   #3988   +/-   ##
===========================================
- Coverage           72%     72%   -0%     
===========================================
  Files              366     366           
  Lines            56869   56862    -7     
  Branches         56869   56862    -7     
===========================================
- Hits             41023   41013   -10     
- Misses           13760   13766    +6     
+ Partials          2086    2083    -3     
Files Changed Coverage Δ
state-chain/pallets/cf-validator/src/lib.rs 74% <100%> (-<1%) ⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@martin-chainflip martin-chainflip merged commit 9976e83 into release/0.9 Sep 12, 2023
44 checks passed
@martin-chainflip martin-chainflip deleted the fix/handover-dont-reset-vault-state branch September 12, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants