Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pla 760 #4000

Closed
wants to merge 41 commits into from
Closed

pla 760 #4000

wants to merge 41 commits into from

Conversation

tomjohnburton
Copy link
Contributor

@tomjohnburton tomjohnburton commented Sep 13, 2023

This job will create a new chainspec if one does not already exists. It will upload the chainspec to our public S3 repo and commit the file to the repo at the release branch.

If we want to phoenix Perseverance or launch a new sisyphos, one simply needs to delete the chainspecs in the direction and then update the bootnode list.

closes pla-760

@linear
Copy link

linear bot commented Sep 13, 2023

PLA-760 Chainspecs should be created in the CI

Release branch

After the build step, we can take that binary and create a chainspec

Then we upload that chainspec to the public repo

Then we commit that chainspec to both main and the release branch, lets do via a PR at first

The CI job need only run if the <chain>.rs file changes

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #4000 (f694634) into main (bf0f2d0) will increase coverage by 0%.
Report is 25 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            main   #4000     +/-   ##
=======================================
  Coverage     72%     72%             
=======================================
  Files        366     368      +2     
  Lines      57289   58484   +1195     
  Branches   57289   58484   +1195     
=======================================
+ Hits       41344   42327    +983     
- Misses     13850   14061    +211     
- Partials    2095    2096      +1     

see 92 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@dandanlen dandanlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible can we make it open a PR or commit to a separate branch? If we do this automatically, someone should at least be aware so they can sanity-check the result.

ci/scripts/create_chainspec.py Outdated Show resolved Hide resolved
ci/scripts/create_chainspec.py Outdated Show resolved Hide resolved
@ahasna ahasna deleted the pla-760 branch May 23, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants