-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pla 760 #4000
pla 760 #4000
Conversation
PLA-760 Chainspecs should be created in the CI
Release branch After the build step, we can take that binary and create a chainspec Then we upload that chainspec to the public repo Then we commit that chainspec to both main and the release branch, lets do via a PR at first The CI job need only run if the |
Codecov Report
@@ Coverage Diff @@
## main #4000 +/- ##
=======================================
Coverage 72% 72%
=======================================
Files 366 368 +2
Lines 57289 58484 +1195
Branches 57289 58484 +1195
=======================================
+ Hits 41344 42327 +983
- Misses 13850 14061 +211
- Partials 2095 2096 +1 see 92 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If possible can we make it open a PR or commit to a separate branch? If we do this automatically, someone should at least be aware so they can sanity-check the result.
Co-authored-by: tomjohnburton <tomjohnburton@users.noreply.github.com>
Co-authored-by: tomjohnburton <tomjohnburton@users.noreply.github.com>
This job will create a new chainspec if one does not already exists. It will upload the chainspec to our public S3 repo and commit the file to the repo at the release branch.
If we want to phoenix Perseverance or launch a new sisyphos, one simply needs to delete the chainspecs in the direction and then update the bootnode list.
closes pla-760