Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: qualify nodes by minimum cfe version #4003

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Conversation

dandanlen
Copy link
Collaborator

Pull Request

Closes: PRO-836

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have updated documentation where appropriate.

Summary

This allows us to set a minimum CFE version in the validator pallet config. Any cfes reporting a version number below this will be excluded from keygen.

@linear
Copy link

linear bot commented Sep 14, 2023

PRO-836 CFE Version based auction qualification

We want to add an extra auction qualification criterion based on the reported cfe versions.

When a new runtime upgrade version is pending in NextCompatibilityVersion in the environment pallet, we should disqualify nodes from auctions if they have not updated their CFE to a compatible version.

May need coordination with the product team to integrate this nicely in the UI david

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #4003 (cfb2385) into main (c00a008) will increase coverage by 0%.
The diff coverage is 84%.

@@          Coverage Diff          @@
##            main   #4003   +/-   ##
=====================================
  Coverage     72%     72%           
=====================================
  Files        366     366           
  Lines      57317   57384   +67     
  Branches   57317   57384   +67     
=====================================
+ Hits       41380   41436   +56     
- Misses     13845   13854    +9     
- Partials    2092    2094    +2     
Files Changed Coverage Δ
state-chain/pallets/cf-funding/src/lib.rs 69% <0%> (ø)
state-chain/runtime/src/lib.rs 39% <ø> (ø)
state-chain/pallets/cf-validator/src/lib.rs 74% <41%> (-1%) ⬇️
state-chain/traits/src/lib.rs 52% <50%> (-1%) ⬇️
state-chain/pallets/cf-validator/src/tests.rs 97% <100%> (+<1%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dandanlen dandanlen enabled auto-merge (squash) September 14, 2023 12:30
@dandanlen dandanlen merged commit 1d3ccfc into main Sep 14, 2023
44 checks passed
@dandanlen dandanlen deleted the feat/qualify-by-cfe-version branch September 14, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants