Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: amm and pools pallet #4005

Merged
merged 31 commits into from
Sep 25, 2023
Merged

doc: amm and pools pallet #4005

merged 31 commits into from
Sep 25, 2023

Conversation

AlastairHolmes
Copy link
Contributor

Just some initial comments, mostly around the amm.

@AlastairHolmes AlastairHolmes changed the title doc: amm and lp pallet doc: amm and pools pallet Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023 •
edited
Loading

Codecov Report

Merging #4005 (2369681) into main (f872142) will increase coverage by 0%.
The diff coverage is 94%.

@@          Coverage Diff          @@
##            main   #4005   +/-   ##
=====================================
  Coverage     72%     72%           
=====================================
  Files        369     369           
  Lines      59264   59276   +12     
  Branches   59264   59276   +12     
=====================================
+ Hits       42644   42665   +21     
+ Misses     14502   14498    -4     
+ Partials    2118    2113    -5
Files Changed Coverage Δ
state-chain/amm/src/common.rs 88% <ø> (ø)
state-chain/amm/src/lib.rs 47% <ø> (ø)
state-chain/amm/src/limit_orders.rs 77% <92%> (+<1%) ⬆️
state-chain/amm/src/range_orders.rs 79% <100%> (+<1%) ⬆️
state-chain/pallets/cf-pools/src/lib.rs 49% <100%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

AlastairHolmes and others added 22 commits September 25, 2023 17:06
@AlastairHolmes
Update state-chain/amm/src/limit_orders.rs
c6aacd3
@AlastairHolmes
Update state-chain/amm/src/limit_orders.rs
93d2760
@AlastairHolmes
Update state-chain/amm/src/limit_orders.rs
fe2945f
@AlastairHolmes
Update state-chain/amm/src/limit_orders.rs
b30d228
@AlastairHolmes
Update state-chain/amm/src/limit_orders.rs
7ca3282
@AlastairHolmes
Update state-chain/amm/src/limit_orders.rs
dd99f62
@AlastairHolmes
Update state-chain/amm/src/limit_orders.rs
c8b0669
@AlastairHolmes
Update state-chain/amm/src/limit_orders.rs
475d452
@AlastairHolmes
Update state-chain/amm/src/limit_orders.rs
5932687
@AlastairHolmes
Update state-chain/amm/src/range_orders.rs
183b13d
@AlastairHolmes
Update state-chain/amm/src/range_orders.rs
8f26b48
@AlastairHolmes
Update state-chain/amm/src/range_orders.rs
4e27eaf
@AlastairHolmes
Update state-chain/amm/src/range_orders.rs
eaf8ed0
@AlastairHolmes
Update state-chain/pallets/cf-pools/src/lib.rs
fb10e2d
@AlastairHolmes
Update state-chain/pallets/cf-pools/src/lib.rs
dd2a1eb
@AlastairHolmes
Update state-chain/pallets/cf-pools/src/lib.rs
1e0d313
@AlastairHolmes
Update state-chain/pallets/cf-pools/src/lib.rs
94dc7ee
@AlastairHolmes
Update state-chain/pallets/cf-pools/src/lib.rs
0f5484b
@AlastairHolmes
Update state-chain/pallets/cf-pools/src/lib.rs
e3bde6c
@AlastairHolmes
Update state-chain/pallets/cf-pools/src/lib.rs
d0f1e7c
@AlastairHolmes
cargo fmt --all
ce4bbca
@AlastairHolmes
corrections
2369681
@AlastairHolmes AlastairHolmes enabled auto-merge (squash) September 25, 2023 15:07
@AlastairHolmes AlastairHolmes merged commit 0aaaaa1 into main Sep 25, 2023
44 checks passed
@AlastairHolmes AlastairHolmes deleted the doc/amm-plus-lp branch September 25, 2023 15:38
dandanlen pushed a commit that referenced this pull request Sep 26, 2023
@AlastairHolmes @dandanlen
doc: amm and pools pallet (#4005)
5c246f2 
* doc: AMM and LP comments

* Update state-chain/amm/src/common.rs

* Update state-chain/amm/src/common.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/range_orders.rs

* Update state-chain/amm/src/range_orders.rs

* Update state-chain/amm/src/range_orders.rs

* Update state-chain/amm/src/range_orders.rs

* Update state-chain/pallets/cf-pools/src/lib.rs

* Update state-chain/pallets/cf-pools/src/lib.rs

* Update state-chain/pallets/cf-pools/src/lib.rs

* Update state-chain/pallets/cf-pools/src/lib.rs

* Update state-chain/pallets/cf-pools/src/lib.rs

* Update state-chain/pallets/cf-pools/src/lib.rs

* Update state-chain/pallets/cf-pools/src/lib.rs

* cargo fmt --all

* corrections
dandanlen pushed a commit that referenced this pull request Sep 26, 2023
@AlastairHolmes @dandanlen
doc: amm and pools pallet (#4005)
da23005 
* doc: AMM and LP comments

* Update state-chain/amm/src/common.rs

* Update state-chain/amm/src/common.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/range_orders.rs

* Update state-chain/amm/src/range_orders.rs

* Update state-chain/amm/src/range_orders.rs

* Update state-chain/amm/src/range_orders.rs

* Update state-chain/pallets/cf-pools/src/lib.rs

* Update state-chain/pallets/cf-pools/src/lib.rs

* Update state-chain/pallets/cf-pools/src/lib.rs

* Update state-chain/pallets/cf-pools/src/lib.rs

* Update state-chain/pallets/cf-pools/src/lib.rs

* Update state-chain/pallets/cf-pools/src/lib.rs

* Update state-chain/pallets/cf-pools/src/lib.rs

* cargo fmt --all

* corrections
dandanlen pushed a commit that referenced this pull request Sep 28, 2023
@AlastairHolmes @dandanlen
doc: amm and pools pallet (#4005)
eb8cc5e 
* doc: AMM and LP comments

* Update state-chain/amm/src/common.rs

* Update state-chain/amm/src/common.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/range_orders.rs

* Update state-chain/amm/src/range_orders.rs

* Update state-chain/amm/src/range_orders.rs

* Update state-chain/amm/src/range_orders.rs

* Update state-chain/pallets/cf-pools/src/lib.rs

* Update state-chain/pallets/cf-pools/src/lib.rs

* Update state-chain/pallets/cf-pools/src/lib.rs

* Update state-chain/pallets/cf-pools/src/lib.rs

* Update state-chain/pallets/cf-pools/src/lib.rs

* Update state-chain/pallets/cf-pools/src/lib.rs

* Update state-chain/pallets/cf-pools/src/lib.rs

* cargo fmt --all

* corrections
dandanlen pushed a commit that referenced this pull request Oct 9, 2023
@AlastairHolmes @dandanlen
doc: amm and pools pallet (#4005)
4d8577b 
* doc: AMM and LP comments

* Update state-chain/amm/src/common.rs

* Update state-chain/amm/src/common.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/limit_orders.rs

* Update state-chain/amm/src/range_orders.rs

* Update state-chain/amm/src/range_orders.rs

* Update state-chain/amm/src/range_orders.rs

* Update state-chain/amm/src/range_orders.rs

* Update state-chain/pallets/cf-pools/src/lib.rs

* Update state-chain/pallets/cf-pools/src/lib.rs

* Update state-chain/pallets/cf-pools/src/lib.rs

* Update state-chain/pallets/cf-pools/src/lib.rs

* Update state-chain/pallets/cf-pools/src/lib.rs

* Update state-chain/pallets/cf-pools/src/lib.rs

* Update state-chain/pallets/cf-pools/src/lib.rs

* cargo fmt --all

* corrections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dandanlen dandanlen dandanlen left review comments

@kylezs kylezs kylezs approved these changes

@martin-chainflip martin-chainflip Awaiting requested review from martin-chainflip

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlastairHolmes @dandanlen @kylezs