Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus metric ceremony #4034

Merged
merged 20 commits into from
Sep 25, 2023

address review comments

d32ddf1
Select commit
Loading
Failed to load commit list.
Merged

Prometheus metric ceremony #4034

address review comments
d32ddf1
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project succeeded Sep 25, 2023 in 1s

72% (-0%) compared to 178df88

Details

Codecov Report

Merging #4034 (d32ddf1) into main (178df88) will decrease coverage by 0%.
Report is 6 commits behind head on main.
The diff coverage is 82%.

@@          Coverage Diff           @@
##            main   #4034    +/-   ##
======================================
- Coverage     72%     72%    -0%     
======================================
  Files        368     369     +1     
  Lines      58484   59126   +642     
  Branches   58484   59126   +642     
======================================
+ Hits       42327   42658   +331     
- Misses     14060   14353   +293     
- Partials    2097    2115    +18     
Files Changed Coverage Δ
...ngine/multisig/src/client/common/ceremony_stage.rs 100% <ø> (ø)
engine/multisig/src/client/ceremony_runner.rs 82% <73%> (+<1%) ⬆️
utilities/src/with_std/metrics.rs 81% <82%> (+1%) ⬆️
engine/multisig/src/client/common/broadcast.rs 87% <94%> (+<1%) ⬆️

... and 25 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more