feat: add initiated_at block number for egresses #4046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4046 +/- ##
======================================
- Coverage 72% 72% -0%
======================================
Files 369 370 +1
Lines 59126 59306 +180
Branches 59126 59306 +180
======================================
+ Hits 42651 42674 +23
- Misses 14357 14508 +151
- Partials 2118 2124 +6
... and 30 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kylezs
force-pushed
the
fix/egress-id-race-condition
branch
from
6be3117 to
e7bf8cf
Compare
kylezs
force-pushed
the
fix/egress-id-race-condition
branch
from
e7bf8cf to
a39d37e
Compare
dandanlen
approved these changes
Sep 26, 2023
| @@ -179,6 +182,9 @@ pub mod pallet { | |||
|
|
|||
| type BroadcastReadyProvider: OnBroadcastReady<Self::TargetChain, ApiCall = Self::ApiCall>; | |||
|
|
|||
| /// Get the latest block height of the target chain via Chain Tracking. | |||
| type ChainTracking: GetBlockHeight<Self::TargetChain>; | |||
There was a problem hiding this comment.
Side note: we should consider adding ChainTracking to the Chainflip trait - it's getting its tentacles in everywhere.
There was a problem hiding this comment.
This made me think that maybe it makes sense to merge the broadcast and ingress-egress pallet actually... after all, the broadcast is egressing transactions... something we can think about anyway.
dandanlen
pushed a commit
that referenced
this pull request
Sep 28, 2023
* feat: add initiated_at block number for egresses * chore: add migration for chain height addition * chore: add migration hooks
dandanlen
pushed a commit
that referenced
this pull request
Sep 29, 2023
* feat: add initiated_at block number for egresses * chore: add migration for chain height addition * chore: add migration hooks
dandanlen
pushed a commit
that referenced
this pull request
Oct 9, 2023
* feat: add initiated_at block number for egresses * chore: add migration for chain height addition * chore: add migration hooks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
First PR of: PRO-689
Second PR will include the CFE side. Figured would split this since it's possible.
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
initiated_atto the on_signature_ready_callback, such that we set it to the earliest possible block number it could be in.