-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add restricted balances to AccountInfoV2 #4048
Conversation
PRO-834 Rpc for restricted SC FLIP balances
The front end needs to be able to display available/restricted funds. See this conversation for details: daniel said in WEB-430:
|
Codecov Report
@@ Coverage Diff @@
## main #4048 +/- ##
=====================================
Coverage 71% 71%
=====================================
Files 377 377
Lines 60029 60090 +61
Branches 60029 60090 +61
=====================================
+ Hits 42766 42818 +52
- Misses 15021 15025 +4
- Partials 2242 2247 +5
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
It's bit more complicated than this I'm afraid. |
I've added some more detail to the Linear issue. |
Thanks @j4m1ef0rd , this looks fine. |
6a4e7c9
to
c52a2c3
Compare
* origin/main: Feat: Set pool fees (#4050) fix: don't egress empty all_batch calls (#4102) fix: don't abort broadcast if signers are unavailable (#4104) feat: add restricted balances to AccountInfoV2 (#4048) feat: use snake case for lp api method names (#4108) feat: add expiry block to liquidity channel event (#4111) # Conflicts: # state-chain/custom-rpc/src/lib.rs # state-chain/runtime/src/lib.rs # state-chain/runtime/src/runtime_apis.rs
Pull Request
Closes: PRO-834
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Added
restricted_balances
field to thecf_account_info_v2
RPC. No idea if this breaks things on the web side.The restricted balances is a map of Eth addresses and amounts.
The available balance =
balance
-bond
, So i did not add it to the struct because the info is already there.Should we add something to the bouncer that checks this new field?