Feat: Set pool fees

[syan095]

Pull Request

Closes: PRO-846

Checklist

Please conduct a thorough self-review before opening the PR.

• I am confident that the code works.
• I have updated documentation where appropriate.

Summary

Added function to set liquidity pool fees.
Changing the pool fees will collect all fees and bought amount for LPer and credit them to Lpers' account.

[linear]

PRO-846 feat: change pool fee

We need the ability to change the pool lp fee. Either we could do this through deleting the pool and recreating it, or via a set fee function (which internally will basically have to do the same).

[codecov]

Codecov Report

Merging #4050 (d006c32) into main (6436088) will increase coverage by 0%.
Report is 5 commits behind head on main.
The diff coverage is 93%.

@@          Coverage Diff           @@
##            main   #4050    +/-   ##
======================================
  Coverage     71%     72%            
======================================
  Files        377     377            
  Lines      60078   60624   +546     
  Branches   60078   60624   +546     
======================================
+ Hits       42810   43485   +675     
+ Misses     15022   14880   -142     
- Partials    2246    2259    +13     

Files	Coverage Δ
state-chain/amm/src/limit_orders.rs	89% <100%> (+12%)	⬆️
state-chain/amm/src/range_orders.rs	82% <100%> (+4%)	⬆️
state-chain/pallets/cf-pools/src/benchmarking.rs	100% <100%> (ø)
state-chain/pallets/cf-pools/src/mock.rs	98% <100%> (+2%)	⬆️
state-chain/runtime/src/runtime_apis.rs	83% <100%> (ø)
state-chain/amm/src/common.rs	88% <88%> (-<1%)	⬇️
state-chain/amm/src/lib.rs	58% <86%> (+11%)	⬆️
state-chain/custom-rpc/src/lib.rs	22% <0%> (+1%)	⬆️
state-chain/pallets/cf-pools/src/tests.rs	99% <100%> (+2%)	⬆️
state-chain/runtime/src/lib.rs	35% <0%> (-<1%)	⬇️
... and 3 more

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[AlastairHolmes]

Thansk 4 da speling corectons :)

[AlastairHolmes]

Just these final comments to handle, and we're good to go I think

[AlastairHolmes]

I missed something. We also need to output the LimitOrderUpdated events too, I think it would be best to factor out the crediting of assetss and deposit of the event into the function "update_limit_order_storage" and maybe change the name of the function.

[AlastairHolmes]

I also pushed some minor some what related stuff, if you can have a look.

[syan095]

@AlastairHolmes
I've made some changes to address your PR comments. Since the original PositionInfo was not tracked at all (in both Pool and AMM), I don't know where I can get the info to fill up the "delta_amount" field in the event. I think in this case, the amount isn't changed for the limit order, so I've made the "increase_or_decrease" and "delta_amount" into a single Option, so this can be set to None for situations like this, where we are only collecting fees and bought_amount and not adjusting the position amount. I'm not sure if this will cause any trouble for the Production/front end. If you have time can you please give this one more look over to see if my changes make sense? thank you!

[AlastairHolmes]

Two things can you inline "update_limit_order_storage", and also change the RangeOrderUpdated event so the handling of the increase and decrease case is the same, i.e. with an option pair. Thanks, then we can merge.