Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: polkadot nonce issue #4054

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Conversation

ramizhasan111
Copy link
Contributor

@ramizhasan111 ramizhasan111 commented Sep 27, 2023

Pull Request

Closes: PRO-xxx

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have updated documentation where appropriate.

Summary

cherrypick to main of this: #4053

@ramizhasan111 ramizhasan111 changed the title fix: move resetting of the proxy account nonce to when constructed tx fix/cherrypick-polkadot-nonce-issue-fix Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #4054 (4aaddab) into main (3c2afa8) will decrease coverage by 0%.
Report is 1 commits behind head on main.
The diff coverage is 67%.

@@          Coverage Diff           @@
##            main   #4054    +/-   ##
======================================
- Coverage     72%     72%    -0%     
======================================
  Files        370     373     +3     
  Lines      59306   59182   -124     
  Branches   59306   59182   -124     
======================================
- Hits       42681   42497   -184     
- Misses     14508   14579    +71     
+ Partials    2117    2106    -11     
Files Coverage Δ
state-chain/chains/src/dot.rs 41% <ø> (ø)
state-chain/pallets/cf-vaults/src/lib.rs 80% <ø> (-<1%) ⬇️
state-chain/pallets/cf-vaults/src/mock.rs 81% <ø> (-<1%) ⬇️
state-chain/runtime/src/chainflip.rs 52% <100%> (+1%) ⬆️
state-chain/runtime/src/lib.rs 39% <ø> (ø)
state-chain/traits/src/lib.rs 51% <ø> (-<1%) ⬇️
state-chain/chains/src/dot/api.rs 20% <50%> (+1%) ⬆️
state-chain/pallets/cf-environment/src/lib.rs 74% <67%> (-1%) ⬇️

... and 33 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

type ReplayProtection = PolkadotReplayProtection;
}

pub type ResetProxyAccountNonce = bool;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type alias for a bool seems unnecessary...

Copy link
Collaborator

@dandanlen dandanlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'd still like to understand how (if?) this caused the observed bug...

@dandanlen dandanlen changed the title fix/cherrypick-polkadot-nonce-issue-fix fix: polkadot nonce issue Sep 28, 2023
@dandanlen dandanlen merged commit 0168147 into main Sep 28, 2023
44 checks passed
@dandanlen dandanlen deleted the fix/polkadot-nonce-issue-cherrypick branch September 28, 2023 13:51
dandanlen pushed a commit that referenced this pull request Sep 28, 2023
dandanlen pushed a commit that referenced this pull request Sep 29, 2023
dandanlen pushed a commit that referenced this pull request Oct 2, 2023
dandanlen pushed a commit that referenced this pull request Oct 4, 2023
dandanlen pushed a commit that referenced this pull request Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants