-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: polkadot nonce issue #4054
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4054 +/- ##
======================================
- Coverage 72% 72% -0%
======================================
Files 370 373 +3
Lines 59306 59182 -124
Branches 59306 59182 -124
======================================
- Hits 42681 42497 -184
- Misses 14508 14579 +71
+ Partials 2117 2106 -11
... and 33 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
type ReplayProtection = PolkadotReplayProtection; | ||
} | ||
|
||
pub type ResetProxyAccountNonce = bool; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type alias for a bool
seems unnecessary...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I'd still like to understand how (if?) this caused the observed bug...
Pull Request
Closes: PRO-xxx
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
cherrypick to main of this: #4053