-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dont merge] runtime upgrade to fix polkadot vault #4055
Conversation
state-chain/runtime/src/lib.rs
Outdated
) => { | ||
ext_builder.force_nonce(nonce); | ||
nonce += 1; | ||
PolkadotBroadcaster::threshold_sign_and_broadcast(transfer); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should also call clean_broadcast_storage for the stuck apicall broadcast (also below).
2130049
to
2095676
Compare
btw we also need to manually reset the nonce in the env pallet after the rotation tx threshold_sign_and_broadcast if my other fix goes into release since it wont reset the nonce on witnessing vault rotation as before. |
Codecov Report
@@ Coverage Diff @@
## release/0.9 #4055 +/- ##
===========================================
- Coverage 72% 72% -0%
===========================================
Files 366 366
Lines 56871 56867 -4
Branches 56871 56867 -4
===========================================
- Hits 41031 41005 -26
- Misses 13759 13773 +14
- Partials 2081 2089 +8
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
when compatibility versions don't match
No description provided.