Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dont merge] runtime upgrade to fix polkadot vault #4055

Closed
wants to merge 9 commits into from

Conversation

dandanlen
Copy link
Collaborator

No description provided.

) => {
ext_builder.force_nonce(nonce);
nonce += 1;
PolkadotBroadcaster::threshold_sign_and_broadcast(transfer);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also call clean_broadcast_storage for the stuck apicall broadcast (also below).

@dandanlen dandanlen force-pushed the fix/runtime-upgrade-fix-dot-vault branch from 2130049 to 2095676 Compare September 27, 2023 13:37
@ramizhasan111
Copy link
Contributor

btw we also need to manually reset the nonce in the env pallet after the rotation tx threshold_sign_and_broadcast if my other fix goes into release since it wont reset the nonce on witnessing vault rotation as before.

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #4055 (cc21fd5) into release/0.9 (0fbf186) will decrease coverage by 0%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           release/0.9   #4055   +/-   ##
===========================================
- Coverage           72%     72%   -0%     
===========================================
  Files              366     366           
  Lines            56871   56867    -4     
  Branches         56871   56867    -4     
===========================================
- Hits             41031   41005   -26     
- Misses           13759   13773   +14     
- Partials          2081    2089    +8     
Files Coverage Δ
state-chain/pallets/cf-vaults/src/lib.rs 79% <ø> (-<1%) ⬇️
state-chain/pallets/cf-vaults/src/mock.rs 82% <ø> (-<1%) ⬇️
state-chain/runtime-upgrade-utilities/src/lib.rs 89% <ø> (ø)
state-chain/runtime/src/lib.rs 39% <ø> (ø)
state-chain/traits/src/lib.rs 52% <ø> (-<1%) ⬇️
state-chain/runtime/src/chainflip.rs 42% <0%> (-1%) ⬇️
state-chain/chains/src/dot.rs 41% <0%> (-<1%) ⬇️
state-chain/chains/src/dot/api.rs 1% <0%> (-<1%) ⬇️
state-chain/pallets/cf-environment/src/lib.rs 67% <0%> (-3%) ⬇️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dandanlen dandanlen closed this Oct 10, 2023
@ahasna ahasna deleted the fix/runtime-upgrade-fix-dot-vault branch May 23, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants