added message when exiting

[marcellorigotti]

Pull Request

Closes: PRO-xxx

Checklist

Please conduct a thorough self-review before opening the PR.

• I am confident that the code works.
• I have updated documentation where appropriate.

Summary

Added a general message when exiting the program:

• Exiting chainflip-engine due to error: {ERR}
• Exiting chainflip-engine due to panic: {PANIC}

[linear]

PRO-359 Engine should log an easy to find/understand message when it exits

Currently when the engine exits if it was due to an error we print "Error: {error}" (by returning the result from the main function). This makes the error message hard to find, and unclear when reading the logs (As it is a generic message that doesn't mention the software is exiting). And it doesn't handle the case of panics (Where currently we print nothing at the point the engine exits).

This message should include the error/panic if there was one.

I imagine something like "Exiting chainflip-engine due to …" which would nicely match the current "Starting chainflip-engine" log.

[codecov]

Codecov Report

Merging #4069 (1cd5c27) into main (e79b88c) will increase coverage by 0%.
Report is 22 commits behind head on main.
The diff coverage is n/a.

@@          Coverage Diff           @@
##            main   #4069    +/-   ##
======================================
  Coverage     71%     72%            
======================================
  Files        377     378     +1     
  Lines      59967   60663   +696     
  Branches   59967   60663   +696     
======================================
+ Hits       42717   43490   +773     
+ Misses     15008   14907   -101     
- Partials    2242    2266    +24     

Files	Coverage Δ
utilities/src/with_std/logging.rs	0% <ø> (ø)

... and 39 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[AlastairHolmes]

I suggest looking at the macro print_starting!, and basically making a macro print_start_and_end that takes an expression something likes

print_start_and_end! {
async {
run_main().await
}
}

You'll need to variants of the macro one for sync code, and one for async code. That way we can do the same thing for the node's usage of print_starting! (i.e. replace it with print_start_and_end).

The only other thing is I suggest putting this around everything, so it is the first and last thing we do in main.

[AlastairHolmes]

You can move the AssertUnwindSafe, and catch_unwind into the macro. Also with the other usage of the macro.

[AlastairHolmes]

Great work, thank you.