Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temp-fix: dry_run always succeeds #4130

Merged
merged 1 commit into from
Oct 20, 2023
Merged

temp-fix: dry_run always succeeds #4130

merged 1 commit into from
Oct 20, 2023

Conversation

marcellorigotti
Copy link
Contributor

@marcellorigotti marcellorigotti commented Oct 17, 2023

Pull Request

Closes: PRO-920

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have updated documentation where appropriate.

Summary

Temp fix for dry_run
This PR contains the same changes of #4124, but for main

@linear
Copy link

linear bot commented Oct 17, 2023

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #4130 (b73bb91) into main (a39591d) will increase coverage by 0%.
The diff coverage is 0%.

@@          Coverage Diff          @@
##            main   #4130   +/-   ##
=====================================
  Coverage     72%     72%           
=====================================
  Files        378     378           
  Lines      60806   60802    -4     
  Branches   60806   60802    -4     
=====================================
- Hits       43632   43631    -1     
+ Misses     14906   14901    -5     
- Partials    2268    2270    +2     
Files Coverage Δ
api/lib/src/lib.rs 31% <0%> (+<1%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kylezs kylezs changed the title temp fix for dry_run temp-fix: dry_run always succeeds Oct 18, 2023
@marcellorigotti marcellorigotti merged commit 51aaed1 into main Oct 20, 2023
44 checks passed
@marcellorigotti marcellorigotti deleted the fixDryRunMain branch October 20, 2023 14:42
marcellorigotti added a commit that referenced this pull request Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants