Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace NumberOrHex #4163

Merged
merged 25 commits into from
Oct 26, 2023
Merged

feat: replace NumberOrHex #4163

merged 25 commits into from
Oct 26, 2023

Conversation

acdibble
Copy link
Contributor

Pull Request

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have updated documentation where appropriate.

Summary

Use the replacement NumberOrHex enum. Its advantage is that it safely serializes integers for languages whose only number type is a double precision floating point (looks sideways towards JS)

@acdibble acdibble requested a review from a team as a code owner October 25, 2023 18:39
@acdibble acdibble requested review from zoheb391 and GabrielBuragev and removed request for a team October 25, 2023 18:39
@acdibble acdibble marked this pull request as draft October 25, 2023 18:39
Base automatically changed from feat/environment-rpc to main October 26, 2023 15:25
@acdibble acdibble marked this pull request as ready for review October 26, 2023 15:32
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #4163 (bcf0b8c) into main (ed0baff) will increase coverage by 0%.
The diff coverage is 66%.

@@          Coverage Diff          @@
##            main   #4163   +/-   ##
=====================================
  Coverage     72%     72%           
=====================================
  Files        379     379           
  Lines      61544   61560   +16     
  Branches   61544   61560   +16     
=====================================
+ Hits       44104   44125   +21     
+ Misses     15140   15136    -4     
+ Partials    2300    2299    -1     
Files Coverage Δ
...lities/src/with_std/serde_helpers/number_or_hex.rs 0% <ø> (ø)
utilities/src/with_std.rs 72% <0%> (ø)
utilities/src/with_std/rpc.rs 98% <95%> (+19%) ⬆️
state-chain/custom-rpc/src/lib.rs 23% <0%> (-<1%) ⬇️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dandanlen dandanlen enabled auto-merge (squash) October 26, 2023 16:06
@dandanlen dandanlen merged commit fb3dfb9 into main Oct 26, 2023
42 checks passed
@dandanlen dandanlen deleted the feat/number-or-hex branch October 26, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants