-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace NumberOrHex #4163
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feat/environment-rpc
… feat/environment-rpc
… feat/environment-rpc
acdibble
requested review from
zoheb391 and
GabrielBuragev
and removed request for
a team
October 25, 2023 18:39
AlastairHolmes
approved these changes
Oct 26, 2023
2 tasks
Codecov Report
@@ Coverage Diff @@
## main #4163 +/- ##
=====================================
Coverage 72% 72%
=====================================
Files 379 379
Lines 61544 61560 +16
Branches 61544 61560 +16
=====================================
+ Hits 44104 44125 +21
+ Misses 15140 15136 -4
+ Partials 2300 2299 -1
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dandanlen
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Use the replacement
NumberOrHex
enum. Its advantage is that it safely serializes integers for languages whose only number type is a double precision floating point (looks sideways towards JS)