-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: PRO-928: engine should wait until funded #4169
Conversation
PRO-928 Don't exit if account is unfunded
This is a regression related to engine version checking with subxt. Previously, if the engine was started before the associated account was funded, it would wait until the funding event. This is no longer the case since we now use subxt for We need to revert to the previous behaviour, while ensuring that an incompatible engine still submits its version number. |
Codecov Report
@@ Coverage Diff @@
## main #4169 +/- ##
======================================
- Coverage 72% 72% -0%
======================================
Files 379 380 +1
Lines 61910 62126 +216
Branches 61910 62126 +216
======================================
+ Hits 44440 44497 +57
- Misses 15150 15306 +156
- Partials 2320 2323 +3
... and 5 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
I'm not going to be able to get to this for a few days, due to higher priority work (LP api). |
…-role-none * origin/main: feature/PRO-898/instantiable-safe-mode (#4168) fix flaky lp_api bouncer check (#4204) feat: automate incompatible CFE upgrade testing (#4196) fix: PRO-928: engine should wait until funded (#4169) fix: Allow basic auth URL (#4197) # Conflicts: # engine/src/state_chain_observer/client/extrinsic_api/signed.rs
No description provided.