Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PRO-928: engine should wait until funded #4169

Merged
merged 7 commits into from
Nov 6, 2023
Merged

fix: PRO-928: engine should wait until funded #4169

merged 7 commits into from
Nov 6, 2023

Conversation

AlastairHolmes
Copy link
Contributor

No description provided.

@linear
Copy link

linear bot commented Oct 27, 2023

PRO-928 Don't exit if account is unfunded

This is a regression related to engine version checking with subxt.

Previously, if the engine was started before the associated account was funded, it would wait until the funding event.

This is no longer the case since we now use subxt for ensure_cfe_version_record_up_to_date, to allow us to submit the version extrinsic dynamically without requiring runtime compatiblity.

We need to revert to the previous behaviour, while ensuring that an incompatible engine still submits its version number.

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #4169 (9d7d5a3) into main (5026646) will decrease coverage by 0%.
The diff coverage is 18%.

@@          Coverage Diff           @@
##            main   #4169    +/-   ##
======================================
- Coverage     72%     72%    -0%     
======================================
  Files        379     380     +1     
  Lines      61910   62126   +216     
  Branches   61910   62126   +216     
======================================
+ Hits       44440   44497    +57     
- Misses     15150   15306   +156     
- Partials    2320    2323     +3     
Files Coverage Δ
state-chain/pallets/cf-account-roles/src/lib.rs 76% <ø> (ø)
state-chain/primitives/src/lib.rs 63% <ø> (ø)
utilities/src/with_std.rs 72% <ø> (ø)
...tate_chain_observer/client/extrinsic_api/signed.rs 0% <0%> (ø)
utilities/src/with_std/cached_stream.rs 82% <0%> (-4%) ⬇️
utilities/src/with_std/try_cached_stream.rs 82% <82%> (ø)
...ne/src/state_chain_observer/client/base_rpc_api.rs 1% <0%> (-<1%) ⬇️
engine/src/state_chain_observer/client/mod.rs 12% <0%> (-3%) ⬇️

... and 5 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@AlastairHolmes
Copy link
Contributor Author

I'm not going to be able to get to this for a few days, due to higher priority work (LP api).

@AlastairHolmes AlastairHolmes requested a review from kylezs November 2, 2023 10:25
@AlastairHolmes AlastairHolmes marked this pull request as ready for review November 2, 2023 10:25
@AlastairHolmes AlastairHolmes requested review from dandanlen and removed request for kylezs November 2, 2023 10:26
@AlastairHolmes AlastairHolmes enabled auto-merge (squash) November 3, 2023 15:36
@dandanlen dandanlen disabled auto-merge November 3, 2023 15:46
@dandanlen dandanlen changed the title fix: PRO-928 fix: PRO-928: engine should wait until funded Nov 3, 2023
@dandanlen dandanlen enabled auto-merge (squash) November 3, 2023 15:47
@dandanlen dandanlen merged commit 6f9e556 into main Nov 6, 2023
41 checks passed
@dandanlen dandanlen deleted the fix/PRO-928 branch November 6, 2023 09:20
syan095 added a commit that referenced this pull request Nov 6, 2023
…-role-none

* origin/main:
  feature/PRO-898/instantiable-safe-mode (#4168)
  fix flaky lp_api bouncer check (#4204)
  feat: automate incompatible CFE upgrade testing (#4196)
  fix: PRO-928: engine should wait until funded (#4169)
  fix: Allow basic auth URL (#4197)

# Conflicts:
#	engine/src/state_chain_observer/client/extrinsic_api/signed.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants