chore: shorten signature offence suspension #4170
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on observations in perseverance, I think it makes sense to shorten this.
When have a lot of false positives (which can happen due to network conditions), we risk banning 'good' nodes. This tens to happen particularly when there is a large volume of simultaneous signature requests.
150 blocks is a long time to wait to recover, and in the meantime, more requests accumulate, making the situation worse.
We still need to suspend misbehaving nodes though, so removing the suspension altogether is not an option.
5 blocks is a decent compromise: it allows for up to 5 retries before the banned nodes come back into play, meaning we strike a balance between flushing out bad nodes, and recovering from network degradation.
In future we might want to consider some form of escalation whereby we hand out longer suspensions for repeat offenders.