Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: shorten signature offence suspension #4170

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

dandanlen
Copy link
Collaborator

Based on observations in perseverance, I think it makes sense to shorten this.

When have a lot of false positives (which can happen due to network conditions), we risk banning 'good' nodes. This tens to happen particularly when there is a large volume of simultaneous signature requests.

150 blocks is a long time to wait to recover, and in the meantime, more requests accumulate, making the situation worse.

We still need to suspend misbehaving nodes though, so removing the suspension altogether is not an option.

5 blocks is a decent compromise: it allows for up to 5 retries before the banned nodes come back into play, meaning we strike a balance between flushing out bad nodes, and recovering from network degradation.

In future we might want to consider some form of escalation whereby we hand out longer suspensions for repeat offenders.

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #4170 (4548e36) into main (ed0baff) will increase coverage by 0%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #4170   +/-   ##
=====================================
  Coverage     72%     72%           
=====================================
  Files        379     379           
  Lines      61544   61548    +4     
  Branches   61544   61548    +4     
=====================================
+ Hits       44104   44124   +20     
+ Misses     15140   15125   -15     
+ Partials    2300    2299    -1     

see 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dandanlen dandanlen merged commit 0e795d9 into main Oct 27, 2023
42 checks passed
@dandanlen dandanlen deleted the chore/fine-tune-signing-suspension branch October 27, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants