Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix label order #4172

Merged
merged 1 commit into from
Oct 30, 2023
Merged

chore: Fix label order #4172

merged 1 commit into from
Oct 30, 2023

Conversation

marcellorigotti
Copy link
Contributor

@marcellorigotti marcellorigotti commented Oct 27, 2023

Pull Request

Closes: PRO-xxx

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have updated documentation where appropriate.

Summary

The order of the label was incorrect, resulting in:

  • I.E. chain="old_ceremony_id", reason="Ethereum"

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #4172 (9c11c8d) into main (c388114) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff          @@
##            main   #4172   +/-   ##
=====================================
  Coverage     72%     72%           
=====================================
  Files        379     379           
  Lines      61548   61548           
  Branches   61548   61548           
=====================================
+ Hits       44118   44121    +3     
+ Misses     15129   15126    -3     
  Partials    2301    2301           
Files Coverage Δ
engine/multisig/src/client/ceremony_manager.rs 77% <100%> (ø)

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dandanlen dandanlen changed the title Bug: Fix label order chore: Fix label order Oct 30, 2023
@dandanlen dandanlen merged commit 5c3b307 into main Oct 30, 2023
42 checks passed
@dandanlen dandanlen deleted the fixLabelIndex branch October 30, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants