Improved error display #4209
Merged
Improved error display #4209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…layed on the front end properly.
PRO-950 RPC result with a DispatchError::Other is empty
When a You can see this bug if you try and call a I believe this bug is caused by the static str inside the |
Codecov Report
@@ Coverage Diff @@
## main #4209 +/- ##
=====================================
- Coverage 71% 71% -0%
=====================================
Files 383 383
Lines 62704 62744 +40
Branches 62704 62744 +40
=====================================
+ Hits 44822 44845 +23
- Misses 15550 15561 +11
- Partials 2332 2338 +6
... and 6 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
j4m1ef0rd
approved these changes
Nov 8, 2023
Improved dry run's debug logging for more clarity
syan095
changed the title
dandanlen
reviewed
Nov 9, 2023
| MissingPolkadotVault, | ||
| /// Bitcoin's Vault key does not exist for the current epoch. | ||
| MissingBitcoinVault, | ||
| /// Intent ID is too large for Bitcoin address derivation |
There was a problem hiding this comment.
Suggested change
| /// Intent ID is too large for Bitcoin address derivation | |
| /// Channel ID is too large for Bitcoin address derivation. |
| /// Bitcoin's Vault key does not exist for the current epoch. | ||
| MissingBitcoinVault, | ||
| /// Intent ID is too large for Bitcoin address derivation | ||
| BitcoinIntentIdTooLarge, |
There was a problem hiding this comment.
Suggested change
| BitcoinIntentIdTooLarge, | |
| BitcoinChannelIdTooLarge, |
There was a problem hiding this comment.
FWIW I think we should probably wrap the channel id counter instead of returning an error. Can wait for another PR.
state-chain/pallets/cf-lp/src/lib.rs
Outdated
| UnauthorisedToModify, | ||
| // The Asset cannot be egressed to the destination chain. | ||
| /// The Asset cannot be egressed to the destination chain. |
There was a problem hiding this comment.
This message doesn't say anything about the address.
dandanlen
pushed a commit
that referenced
this pull request
Nov 17, 2023
* Changed a DispatchError::Other() to a pallet error, so it can be displayed on the front end properly. * Replaced DispatchError::Other with module error for better display Improved dry run's debug logging for more clarity * minor rename
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: PRO-950
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Changed invalid BTC address error for lp_withdraw_asset from DispatchError::Other() to a pallet error, so it can be displayed on the front end properly.