-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: charge a fee for opening swap deposit addresses #4512
Conversation
Kyle mentioned that it might make sense to apply the fee to all channels (swap and lp), and i agree. So i moved it into the ingress/egress pallet. I also moved the fee to the rpcs instead of returning it in the apis. |
0ea8b3d
to
747c608
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4512 +/- ##
======================================
Coverage 73% 73%
======================================
Files 401 401
Lines 68051 68283 +232
Branches 68051 68283 +232
======================================
+ Hits 49451 49640 +189
- Misses 15973 15978 +5
- Partials 2627 2665 +38 ☔ View full report in Codecov by Sentry. |
@acdibble some environment RPC snapshots changing here |
Sorry @acdibble I thought you would be auto-tagged for the review. The change is an additional item It will be set to zero initially but that might change ofc. |
e2bd018
to
68704e6
Compare
…igned-error * origin/main: chore: fetch solana state from docker (#4538) feat: charge a fee for opening swap deposit addresses (#4512) refactor: Remove RpcAsset (PRO-1187) (#4491) fix: re-add version update (#4533) fix: pull first (#4526) feat: auto pick non-breaking changes (#4498) # Conflicts: # state-chain/pallets/cf-ingress-egress/src/lib.rs # state-chain/pallets/cf-ingress-egress/src/tests.rs
Pull Request
Closes: PRO-1134
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Charges a fee for opening swap channels.
Currently the fee is zero, can be set using the new governance extrinsic
update_pallet_config
.Bonus feature: it's now possible to do multiple updates at once (eg. update all the swap limits at once).