feat: more information added to AllBatchError. (PRO-1171) #4535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When AllBatch build fails, an event is emitted that contains the error, this way both the pallet and the error details is visible.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4535 +/- ##
======================================
- Coverage 73% 73% -0%
======================================
Files 401 401
Lines 68357 68184 -173
Branches 68357 68184 -173
======================================
- Hits 49832 49585 -247
- Misses 15895 15973 +78
+ Partials 2630 2626 -4 ☔ View full report in Codecov by Sentry. |
dandanlen
requested changes
Feb 15, 2024
Comment on lines
1496
to
1497
| crate::Event::<Test>::FailedToBuildAllBatchCall { | ||
| error: cf_chains::AllBatchError::Other, |
There was a problem hiding this comment.
I think this test passes because calling do_egress_scheduled_fetch_transfer outside of a transactional wrapper doesn't roll back the storage.
A better approach might be to refactor do_egress_scheduled_fetch_transfer so that it returns a Result and simply decorate the fn with #[transactional].
…igned-error * origin/main: chore: fetch solana state from docker (#4538) feat: charge a fee for opening swap deposit addresses (#4512) refactor: Remove RpcAsset (PRO-1187) (#4491) fix: re-add version update (#4533) fix: pull first (#4526) feat: auto pick non-breaking changes (#4498) # Conflicts: # state-chain/pallets/cf-ingress-egress/src/lib.rs # state-chain/pallets/cf-ingress-egress/src/tests.rs
kylezs
reviewed
Feb 16, 2024
dandanlen
approved these changes
Feb 16, 2024
dandanlen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: PRO-1171
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
When AllBatch build fails, an event is emitted that contains the error, this way both the pallet and the error details is visible.