Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: avoid extra allocation #4542

Merged
merged 1 commit into from
Feb 19, 2024
Merged

chore: avoid extra allocation #4542

merged 1 commit into from
Feb 19, 2024

Conversation

kylezs
Copy link
Contributor

@kylezs kylezs commented Feb 16, 2024

Just noticed this when I was debugging

@kylezs kylezs requested a review from msgmaxim as a code owner February 16, 2024 14:17
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3d1e872) 73% compared to head (57e3642) 73%.
Report is 3 commits behind head on main.

Files Patch % Lines
engine/multisig/src/client.rs 50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #4542   +/-   ##
=====================================
- Coverage     73%     73%   -0%     
=====================================
  Files        401     401           
  Lines      68206   68184   -22     
  Branches   68206   68184   -22     
=====================================
- Hits       49611   49587   -24     
- Misses     15963   15973   +10     
+ Partials    2632    2624    -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kylezs kylezs merged commit b379633 into main Feb 19, 2024
43 checks passed
@kylezs kylezs deleted the chore/no-alloc branch February 19, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants