-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose command for broker fee withdrawal #4581
Merged
Merged
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
1bffe80
add command for broker fee withdrawal
marcellorigotti b04110d
fmt
marcellorigotti 111eae4
addressed comments
marcellorigotti acb967a
address comments
marcellorigotti 3337aec
import format! macro
marcellorigotti b8998db
fix: use String in place of EncodedAddress
dandanlen 6095c59
Merge branch 'main' into feature/pro-1219
dandanlen e89f3f4
fix: clippy
dandanlen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -356,6 +356,22 @@ pub trait BrokerApi: SignedExtrinsicApi { | |
bail!("No SwapDepositAddressReady event was found"); | ||
} | ||
} | ||
async fn withdraw_fee_asset( | ||
&self, | ||
asset: Asset, | ||
destination_address: EncodedAddress, | ||
) -> Result<H256> { | ||
let (tx_hash, ..) = self | ||
.submit_signed_extrinsic(RuntimeCall::from(pallet_cf_swapping::Call::withdraw { | ||
asset, | ||
destination_address, | ||
})) | ||
.await | ||
.until_in_block() | ||
.await | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. At this point we can also get the egress details, we should return these too. |
||
.context("Request to withdraw broker fee for ${asset} failed.")?; | ||
Ok(tx_hash) | ||
} | ||
} | ||
|
||
/// Sanitize the given address (hex or base58) and turn it into a EncodedAddress of the given | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, better to return the hash here and rely on Serialize rather than converting to a string explicitly.