feat: add block height and deposit details to PrewitnessedDeposit #4606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4606 +/- ##
======================================
- Coverage 73% 73% -0%
======================================
Files 401 401
Lines 66931 66822 -109
Branches 66931 66822 -109
======================================
- Hits 48614 48450 -164
- Misses 15973 16026 +53
- Partials 2344 2346 +2 ☔ View full report in Codecov by Sentry. |
kylezs
approved these changes
Mar 5, 2024
dandanlen
approved these changes
Mar 5, 2024
syan095
added a commit
that referenced
this pull request
Mar 7, 2024
…ncoding * origin/main: (21 commits) chore: update chainspecs (#4615) feat: Add channel opening fee to *DepositAddressReady Events (#4609) refactor: pass out CFE incompatibility exit information to main (#4563) feat: Introduce tx fee multiplier storage item (#4594) fix: debug cli (#4605) fix: patch 1.2 broker test (#4607) feat: add block height and deposit details to PrewitnessedDeposit (#4606) chore: add myself as codeowner to upgrade-test (#4603) fix: RUSTSEC-2024-0019 (#4604) fix: upgrade test pnpm install from commit (#4600) chore: add notification on failed release build (#4589) chore: add Zellic audit to Security.md (#4599) update changelog for 1.2.1 (#4597) fix: use correct pnpm deps for upgrade-test (#4596) chore(bouncer): Use stable sdk version (#4595) chore(bouncer): Update sdk to 1.2.1 (#4582) log meaningful message if docker login fails (#4553) Added bouncer command to download a runtime update from a proposal (#4592) chore: add asset to withdrawal event (#4590) ingress-egress-tracker: add tx_ref to redis (#4573) ... # Conflicts: # state-chain/runtime/src/lib.rs
syan095
added a commit
that referenced
this pull request
Mar 10, 2024
…utxo * origin/main: fix "get_proposed_runtime" command (#4624) fix: allow OldAsset to support unambiguously encoding Arb USDC and Eth USDC, while maintaining backcompat (PRO-1237) (#4614) fix: start localnet using correct commit (#4623) chore: migration housekeeping (#4612) feat: add arbitrum support (PRO-1154) (#4486) fix: swap subscription amounts as hex (#4611) feat: use swapping queue when swapping network fee for burn (#4584) chore: update chainspecs (#4615) feat: Add channel opening fee to *DepositAddressReady Events (#4609) refactor: pass out CFE incompatibility exit information to main (#4563) feat: Introduce tx fee multiplier storage item (#4594) fix: debug cli (#4605) fix: patch 1.2 broker test (#4607) feat: add block height and deposit details to PrewitnessedDeposit (#4606) chore: add myself as codeowner to upgrade-test (#4603) fix: RUSTSEC-2024-0019 (#4604) # Conflicts: # state-chain/pallets/cf-environment/src/lib.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
(In preparation for PRO-1145)
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Split these changes from #4602 to avoid potential future migrations (since that PR will to be delayed now). These fields will be necessary when emitting events after performing the correponding channel action.