fix: scale types for pending ceremonies #5286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5286 +/- ##
=======================================
+ Coverage 70% 71% +1%
=======================================
Files 487 491 +4
Lines 87295 85245 -2050
Branches 87295 85245 -2050
=======================================
- Hits 61312 60640 -672
+ Misses 22703 21891 -812
+ Partials 3280 2714 -566 ☔ View full report in Codecov by Sentry. |
dandanlen
reviewed
Sep 20, 2024
dandanlen
reviewed
Oct 2, 2024
|
In fact it doesn't even have to be a NAME string, it just has to be something we can match on. |
dandanlen
reviewed
Oct 2, 2024
dandanlen
changed the title
dandanlen
approved these changes
Oct 18, 2024
syan095
added a commit
that referenced
this pull request
Oct 23, 2024
* origin/main: feat: broker can encode btc smart contract call (#5329) chore: localnet recreate script can use defaults (#5338) feat: witnessing btc smart contract swaps (#5331) feat: Solana CCM fallback (#5316) fix: scale types for pending ceremonies (#5286) chore: Prune historical values in Validator pallet (#5292) feat: expose deposit transaction hash from ingress-egress-tracker (#5320) # Conflicts: # Cargo.lock # engine/src/witness/btc/smart_contract.rs
syan095
added a commit
that referenced
this pull request
Oct 29, 2024
…waps-close-accounts * origin/main: (44 commits) fix: expire all previous epochs (#5279) feat: add/update contract swaps parameters (#5343) chore: add address to solana logging (#5353) fix: ignore dust underflows in order fills rpc (#5352) chore: consistent naming prewitnessed (#5351) feat: engine-runner verifies gpg signature of old dylib when downloaded (#5339) feat: tainted transaction reporting (#5310) bug: change_utxo not always present (#5340) feat: structured error return types for rpcs (#5346) chore: unify dependencies to root cargo.toml (#5333) feat: Submit a slot number alongside nonce (#5297) chore: use node version from `.nvmrc` 📌 (#5336) chore: add engine account_info logging (#5347) chore: replace manual scale encoding for ts-scale (#5335) chore: more consistent params in Broker API (#5342) feat: broker can encode btc smart contract call (#5329) chore: localnet recreate script can use defaults (#5338) feat: witnessing btc smart contract swaps (#5331) feat: Solana CCM fallback (#5316) fix: scale types for pending ceremonies (#5286) ... # Conflicts: # Cargo.lock # state-chain/chains/src/sol/api.rs # state-chain/pallets/cf-broadcast/src/migrations.rs # state-chain/pallets/cf-environment/Cargo.toml
dandanlen
pushed a commit
that referenced
this pull request
Oct 30, 2024
* Ensure correct decoding of pending ceremonies using substrates reference code for SCALE types * added type check * identify implementation via ChainCrypto instead of Chain * name fields and types
dandanlen
pushed a commit
that referenced
this pull request
Oct 31, 2024
* Ensure correct decoding of pending ceremonies using substrates reference code for SCALE types * added type check * identify implementation via ChainCrypto instead of Chain * name fields and types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: PRO-1676
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
This change renames the types returned by the ThresholdSignature -> pendingCeremonies call so that different types have different names.