chore: Prune historical values in Validator pallet #5292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes: - Implemented for AuthorityIndex, HistoricalAuthorities, HistoricalBonds - Deleting values on epoch expiry - Migration for deleting values for *all* previously expired epochs - Tests for migration and epoch expiry
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5292 +/- ##
=====================================
- Coverage 70% 70% -0%
=====================================
Files 487 488 +1
Lines 87426 87442 +16
Branches 87426 87442 +16
=====================================
- Hits 61505 61431 -74
- Misses 22642 22725 +83
- Partials 3279 3286 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dandanlen
reviewed
Sep 26, 2024
dandanlen
approved these changes
Oct 18, 2024
dandanlen
deleted the
chore/prune-historical-values-in-validator-pallet
branch
syan095
added a commit
that referenced
this pull request
Oct 23, 2024
* origin/main: feat: broker can encode btc smart contract call (#5329) chore: localnet recreate script can use defaults (#5338) feat: witnessing btc smart contract swaps (#5331) feat: Solana CCM fallback (#5316) fix: scale types for pending ceremonies (#5286) chore: Prune historical values in Validator pallet (#5292) feat: expose deposit transaction hash from ingress-egress-tracker (#5320) # Conflicts: # Cargo.lock # engine/src/witness/btc/smart_contract.rs
dandanlen
pushed a commit
that referenced
this pull request
Oct 30, 2024
* Add first attempt at pruning. This includes: - Implemented for AuthorityIndex, HistoricalAuthorities, HistoricalBonds - Deleting values on epoch expiry - Migration for deleting values for *all* previously expired epochs - Tests for migration and epoch expiry * Remove comments (noted in review).
dandanlen
pushed a commit
that referenced
this pull request
Oct 31, 2024
* Add first attempt at pruning. This includes: - Implemented for AuthorityIndex, HistoricalAuthorities, HistoricalBonds - Deleting values on epoch expiry - Migration for deleting values for *all* previously expired epochs - Tests for migration and epoch expiry * Remove comments (noted in review).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: PRO-1318
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Currently some epoch-indexed storage values are not deleted when their epoch is expiring. This PR adds logic to delete these storage values.
This includes:
expire_epochNon-Breaking changes
If this PR includes non-breaking changes, select the
non-breakinglabel. On merge, CI will automatically cherry-pick the commit to a PR against the release branch.