Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cleanup aborted broadcasts #5301

Merged
merged 5 commits into from
Oct 8, 2024
Merged

Conversation

j4m1ef0rd
Copy link
Contributor

@j4m1ef0rd j4m1ef0rd commented Sep 27, 2024

Pull Request

Closes: PRO-1609

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have written sufficient tests.
  • I have written and tested required migrations.
  • I have updated documentation where appropriate.

Summary

  • Now removing an aborted broadcast when it gets witnessed successful.
    • Added a unit test to cover cleanup after a manual broadcast.
  • Added a housekeeping migration that removes the stale aborted broadcasts on mainnet and perseverance.
    • Tested this with a try-runtime against mainnet & perseverance.

@j4m1ef0rd j4m1ef0rd requested a review from kylezs September 27, 2024 05:11
@j4m1ef0rd j4m1ef0rd self-assigned this Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 22 lines in your changes missing coverage. Please review.

Project coverage is 70%. Comparing base (6594d20) to head (91cbb5c).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
state-chain/runtime/src/migrations/housekeeping.rs 0% 17 Missing ⚠️
...adcast/src/migrations/remove_aborted_broadcasts.rs 0% 5 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #5301    +/-   ##
======================================
  Coverage     70%     70%            
======================================
  Files        487     490     +3     
  Lines      87463   87771   +308     
  Branches   87463   87771   +308     
======================================
+ Hits       61511   61761   +250     
- Misses     22672   22701    +29     
- Partials    3280    3309    +29     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kylezs
Copy link
Contributor

kylezs commented Oct 2, 2024

There are Polkadot ones on Perseverance now, FYI @j4m1ef0rd

@j4m1ef0rd j4m1ef0rd requested a review from dandanlen October 4, 2024 04:17
Comment on lines 12 to 13
pub struct EthereumMigration;
pub struct ArbitrumMigration;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These can be deleted.

@dandanlen dandanlen added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit 864e6d2 Oct 8, 2024
49 checks passed
@dandanlen dandanlen deleted the feat/cleanup-aborted-broadcasts branch October 8, 2024 15:46
syan095 added a commit that referenced this pull request Oct 9, 2024
…lana-ccm

* origin/main:
  chore: update polkadot sdk 1.15.2, rust to 2024-07-31 (#5306)
  chore: add sol min_prio_fee to ingress and egress estimation (#5323)
  docs: fix log filtering in readme (#5319)
  feat: cleanup aborted broadcasts (#5301)
  fix: increase init timeout for backup test (#5317)
  feat: minimum chunk size setting (#5314)
  chore: add egress fee for token account rent (#5315)
  fix: ensure unused sol deposit channels are closed (#5312)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants