Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump asset-balances to match release #5305

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Conversation

kylezs
Copy link
Contributor

@kylezs kylezs commented Oct 1, 2024

Summary

Version bump had not yet been pulled across to main from release - meaning try-runtime/migrations would fail due to version mismatch.

See: ea83d71

@kylezs kylezs requested a review from dandanlen as a code owner October 1, 2024 06:50
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70%. Comparing base (ec6c5b7) to head (0f74729).
Report is 4 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff           @@
##            main   #5305    +/-   ##
======================================
- Coverage     70%     70%    -0%     
======================================
  Files        487     487            
  Lines      87665   87521   -144     
  Branches   87665   87521   -144     
======================================
- Hits       61678   61476   -202     
- Misses     22675   22728    +53     
- Partials    3312    3317     +5     
Flag Coverage Δ
70% <ø> (-<1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dandanlen dandanlen added this pull request to the merge queue Oct 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 1, 2024
@kylezs
Copy link
Contributor Author

kylezs commented Oct 1, 2024

Need to bump old engine version to 1.6.7 - this is why PRs were passing before, since it was using 1.6.3 which had asset-balances at version 0, waiting for Anton to upload the 1.6.7 directory as it's expected by the engine-runner then will push.

@kylezs kylezs enabled auto-merge October 1, 2024 10:05
@kylezs kylezs added this pull request to the merge queue Oct 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 1, 2024
@kylezs
Copy link
Contributor Author

kylezs commented Oct 1, 2024

1.5.1 .so file needs to be added to the bin.zip - Anton will do after his lunch

@kylezs kylezs added this pull request to the merge queue Oct 1, 2024
Merged via the queue into main with commit 820c5f9 Oct 1, 2024
49 checks passed
@kylezs kylezs deleted the chore/bump-asset-balances branch October 1, 2024 13:28
syan095 added a commit that referenced this pull request Oct 2, 2024
…-sdk-1.15.2

* origin/main: (31 commits)
  feat: liveness electoral system (#5278)
  chore: bump asset-balances to match release (#5305)
  refactor: Strongly-typed identifiers for SwapId/SwapRequestId (#5294)
  fix: only install solana if `run-job` is true 🐛 (#5304)
  Chore/debug 3 nodes (#5302)
  feat: remove swap and retry batch on price impact (#5285)
  refactor: Collect settings extrinsic in threshold signer pallet into a single extrinsic (#5299)
  feat: add solana monitoring data (#5277)
  fix: Redemption amount printed not consistent in rounding (#5296)
  refactor: use chainflip api for DCA test (#5289)
  fix: add audit exception for RUSTSEC-2024-0375 (#5303)
  fix: filter out stale bitcoin utxos (#5291)
  PRO-1594: Add healthcheck endpoints to broker and lp apis (#5282)
  Tests elections pallet (#5190)
  PRO-1620: Ensure that default port is used if none is given in configuration (#5281)
  test: egress success tests (#5288)
  feat: localnet scripts to create and recreate easier (#5284)
  Denote broadcast timeout in target chain blocks. (#5270)
  fix: force version bump endpoint (#5280)
  refactor: user friendly bouncer new swap cmd  (#5273)
  ...

# Conflicts:
#	.zepter.yaml
#	Cargo.lock
#	api/bin/chainflip-cli/Cargo.toml
#	api/bin/chainflip-lp-api/src/main.rs
#	engine/Cargo.toml
#	state-chain/custom-rpc/Cargo.toml
#	state-chain/custom-rpc/src/lib.rs
#	state-chain/pallets/cf-swapping/src/lib.rs
#	state-chain/runtime/src/monitoring_apis.rs
#	utilities/Cargo.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants