Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Solana Vault swaps (base PR) #5309

Merged
merged 25 commits into from
Nov 12, 2024

Conversation

albert-llimos
Copy link
Contributor

@albert-llimos albert-llimos commented Oct 2, 2024

Pull Request

Closes: PRO-1630, PRO-1631

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have written sufficient tests.
  • I have written and tested required migrations.
  • I have updated documentation where appropriate.

Summary

Missing the migration to add the new variables into the environment. Done

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 47.19101% with 94 lines in your changes missing coverage. Please review.

Project coverage is 71%. Comparing base (420429c) to head (e3add5b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...-environment/src/migrations/sol_api_environment.rs 0% 58 Missing ⚠️
state-chain/chains/src/sol/api.rs 0% 24 Missing ⚠️
state-chain/node/src/chain_spec.rs 29% 12 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #5309    +/-   ##
======================================
- Coverage     72%     71%    -0%     
======================================
  Files        487     488     +1     
  Lines      86183   86224    +41     
  Branches   86183   86224    +41     
======================================
- Hits       61633   61523   -110     
- Misses     21636   21784   +148     
- Partials    2914    2917     +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albert-llimos albert-llimos changed the title Feat/solana program swaps close accounts feat: Solana add swapEndpoint Oct 2, 2024
@albert-llimos albert-llimos changed the title feat: Solana add swapEndpoint feat: Solana add swapEndpoint and closeEventAccounts Api Oct 7, 2024
@albert-llimos albert-llimos marked this pull request as ready for review October 14, 2024 09:13
@albert-llimos
Copy link
Contributor Author

We will create PRs on top of this one for the Solana Program Swap feature. Therefore I'd not merge this to main and merge the other PRs onto this one. Once the feature is complete we can then merge it to main.

albert-llimos and others added 2 commits October 16, 2024 14:35
* chore: first iteration adding anchor

* chore: small cleanup

* chore: syntax improvement

* chore: add comment

* chore: update compute units
@albert-llimos albert-llimos changed the title feat: Solana add swapEndpoint and closeEventAccounts Api feat: Solana Vault swaps (base PR) Oct 23, 2024
…waps-close-accounts

* origin/main: (44 commits)
  fix: expire all previous epochs (#5279)
  feat: add/update contract swaps parameters (#5343)
  chore: add address to solana logging (#5353)
  fix: ignore dust underflows in order fills rpc (#5352)
  chore: consistent naming prewitnessed (#5351)
  feat: engine-runner verifies gpg signature of old dylib when downloaded (#5339)
  feat: tainted transaction reporting (#5310)
  bug: change_utxo not always present (#5340)
  feat: structured error return types for rpcs (#5346)
  chore: unify dependencies to root cargo.toml (#5333)
  feat: Submit a slot number alongside nonce (#5297)
  chore: use node version from `.nvmrc` 📌 (#5336)
  chore: add engine account_info logging (#5347)
  chore: replace manual scale encoding for ts-scale (#5335)
  chore: more consistent params in Broker API (#5342)
  feat: broker can encode btc smart contract call (#5329)
  chore: localnet recreate script can use defaults (#5338)
  feat: witnessing btc smart contract swaps (#5331)
  feat: Solana CCM fallback (#5316)
  fix: scale types for pending ceremonies (#5286)
  ...

# Conflicts:
#	Cargo.lock
#	state-chain/chains/src/sol/api.rs
#	state-chain/pallets/cf-broadcast/src/migrations.rs
#	state-chain/pallets/cf-environment/Cargo.toml
@albert-llimos albert-llimos added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit 2d727e6 Nov 12, 2024
49 checks passed
@albert-llimos albert-llimos deleted the feat/solana-program-swaps-close-accounts branch November 12, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants