Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure unused sol deposit channels are closed #5312

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

dandanlen
Copy link
Collaborator

@dandanlen dandanlen commented Oct 4, 2024

Cherry pick from release/1.6

Closes PRO-1683

@dandanlen dandanlen requested a review from kylezs as a code owner October 4, 2024 08:39
@dandanlen dandanlen changed the title [CHERRY PICK - DO NOT SQUASH] relase-v1.6.7 [CHERRY PICK - DO NOT SQUASH] release-v1.6.7 Oct 4, 2024
@dandanlen dandanlen changed the title [CHERRY PICK - DO NOT SQUASH] release-v1.6.7 fix: ensure unused sol deposit channels are closed Oct 4, 2024
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 70%. Comparing base (839eb60) to head (e827c66).

Files with missing lines Patch % Lines
engine/src/witness/sol/sol_deposits.rs 0% 3 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #5312    +/-   ##
======================================
- Coverage     70%     70%    -0%     
======================================
  Files        489     489            
  Lines      87874   87731   -143     
  Branches   87874   87731   -143     
======================================
- Hits       61939   61737   -202     
- Misses     22630   22682    +52     
- Partials    3305    3312     +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dandanlen dandanlen added this pull request to the merge queue Oct 7, 2024
Merged via the queue into main with commit 4aa38bb Oct 7, 2024
49 checks passed
@dandanlen dandanlen deleted the pick/close-unused-solana-channels branch October 7, 2024 10:03
syan095 added a commit that referenced this pull request Oct 9, 2024
…lana-ccm

* origin/main:
  chore: update polkadot sdk 1.15.2, rust to 2024-07-31 (#5306)
  chore: add sol min_prio_fee to ingress and egress estimation (#5323)
  docs: fix log filtering in readme (#5319)
  feat: cleanup aborted broadcasts (#5301)
  fix: increase init timeout for backup test (#5317)
  feat: minimum chunk size setting (#5314)
  chore: add egress fee for token account rent (#5315)
  fix: ensure unused sol deposit channels are closed (#5312)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants