chore: add egress fee for token account rent #5315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5315 +/- ##
======================================
- Coverage 70% 70% -0%
======================================
Files 489 489
Lines 87875 87735 -140
Branches 87875 87735 -140
======================================
- Hits 61938 61744 -194
- Misses 22630 22684 +54
Partials 3307 3307 ☔ View full report in Codecov by Sentry. |
dandanlen
approved these changes
Oct 7, 2024
| @@ -38,6 +38,7 @@ pub const MAX_TRANSACTION_LENGTH: usize = 1_232usize; | |||
| pub const MAX_COMPUTE_UNITS_PER_TRANSACTION: u32 = 1_400_000u32; | |||
| pub const MICROLAMPORTS_PER_LAMPORT: u32 = 1_000_000u32; | |||
| pub const LAMPORTS_PER_SIGNATURE: u64 = 5000u64; | |||
| pub const RENT_TOKEN_ACCOUNT: u64 = 2039280u64; | |||
There was a problem hiding this comment.
nit: the name is a bit confusing, I think TOKEN_ACCOUNT_RENT would be better.
kylezs
added a commit
that referenced
this pull request
Oct 9, 2024
dandanlen
pushed a commit
that referenced
this pull request
Oct 9, 2024
syan095
added a commit
that referenced
this pull request
Oct 9, 2024
…lana-ccm * origin/main: chore: update polkadot sdk 1.15.2, rust to 2024-07-31 (#5306) chore: add sol min_prio_fee to ingress and egress estimation (#5323) docs: fix log filtering in readme (#5319) feat: cleanup aborted broadcasts (#5301) fix: increase init timeout for backup test (#5317) feat: minimum chunk size setting (#5314) chore: add egress fee for token account rent (#5315) fix: ensure unused sol deposit channels are closed (#5312)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: PRO-1707
Checklist
Please conduct a thorough self-review before opening the PR.