feat: expose deposit transaction hash from ingress-egress-tracker #5320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5320 +/- ##
=======================================
+ Coverage 70% 71% +1%
=======================================
Files 489 490 +1
Lines 87874 85073 -2801
Branches 87874 85073 -2801
=======================================
- Hits 61939 60465 -1474
+ Misses 22630 21891 -739
+ Partials 3305 2717 -588 ☔ View full report in Codecov by Sentry. |
jerryafr
requested review from
zoheb391 and
acdibble
and removed request for
a team
acdibble
reviewed
Oct 15, 2024
api/bin/chainflip-ingress-egress-tracker/src/witnessing/state_chain.rs
Outdated
Show resolved
Hide resolved
api/bin/chainflip-ingress-egress-tracker/src/witnessing/state_chain.rs
Outdated
Show resolved
Hide resolved
api/bin/chainflip-ingress-egress-tracker/src/witnessing/state_chain.rs
Outdated
Show resolved
Hide resolved
zoheb391
approved these changes
Oct 15, 2024
acdibble
approved these changes
Oct 15, 2024
syan095
added a commit
that referenced
this pull request
Oct 23, 2024
* origin/main: feat: broker can encode btc smart contract call (#5329) chore: localnet recreate script can use defaults (#5338) feat: witnessing btc smart contract swaps (#5331) feat: Solana CCM fallback (#5316) fix: scale types for pending ceremonies (#5286) chore: Prune historical values in Validator pallet (#5292) feat: expose deposit transaction hash from ingress-egress-tracker (#5320) # Conflicts: # Cargo.lock # engine/src/witness/btc/smart_contract.rs
dandanlen
pushed a commit
that referenced
this pull request
Oct 30, 2024
) * feat: expose deposit transaction hash from ingress-egress-tracker [WEB-1511] * fixes * make deposit_details optional * fix tests
dandanlen
pushed a commit
that referenced
this pull request
Oct 31, 2024
) * feat: expose deposit transaction hash from ingress-egress-tracker [WEB-1511] * fixes * make deposit_details optional * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: [WEB-1511]
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Please include a succinct description of the purpose and content of the PR. What problem does it solve, and how? Link issues, discussions, other PRs, and anything else that will help the reviewer.
Non-Breaking changes
If this PR includes non-breaking changes, select the
non-breakinglabel. On merge, CI will automatically cherry-pick the commit to a PR against the release branch.