test(bouncer): add test for new utility #5324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acdibble
commented
Oct 9, 2024
| @@ -32,6 +32,7 @@ const getCachedDisposable = <T extends AsyncDisposable, F extends (...args: any[ | |||
| get(target, prop, receiver) { | |||
| if (prop === Symbol.asyncDispose) { | |||
| return () => { | |||
| connections -= 1; | |||
There was a problem hiding this comment.
i accidentally removed this months ago?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5324 +/- ##
======================================
- Coverage 71% 71% -0%
======================================
Files 488 488
Lines 84898 84762 -136
Branches 84898 84762 -136
======================================
- Hits 60376 60185 -191
- Misses 21822 21874 +52
- Partials 2700 2703 +3 ☔ View full report in Codecov by Sentry. |
acdibble
commented
Oct 9, 2024
Comment on lines
+45
to
+49
| { | ||
| refundAddress: '0xa56A6be23b6Cf39D9448FF6e897C29c41c8fbDFF', | ||
| minPriceX128: '1', | ||
| retryDurationBlocks: 100, | ||
| }, // FoK parameters |
There was a problem hiding this comment.
the SDK requires FoK parameters now for any DCA swap
j4m1ef0rd
approved these changes
Oct 10, 2024
GabrielBuragev
approved these changes
Oct 10, 2024
syan095
added a commit
that referenced
this pull request
Oct 14, 2024
…lana-ccm * origin/main: ci: upgrade action version to supress deprecation warnings ⚙️ (#5330) feat: handle rotation tx construction failures (#5307) test(bouncer): add test for new utility (#5324) fix: keyholder check should use `HistoricalActiveEpochs` (#5325) feat: BTC contract swap encoding (#5311)
dandanlen
pushed a commit
that referenced
this pull request
Oct 30, 2024
* test(bouncer): add test for new utility * run test * add dca params * change logs * code review suggestion * call function
dandanlen
pushed a commit
that referenced
this pull request
Oct 31, 2024
* test(bouncer): add test for new utility * run test * add dca params * change logs * code review suggestion * call function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: WEB-1499
Summary
To enable integrators to more securely submit extrinsics to open swap deposit channels outside of the broker API, I created a helper that will go in the SDK that will return the parameters properly formatted for them, ready for submission with the Polkadot API.
This adds a test that ensures that the parameters that are generated by the utility submit the extrinsic to the state chain successfully and open channels with the expected attributes.
Also there are some type fixes (I can't help myself).