Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: split out composite electoral system trait #5334

Merged
merged 18 commits into from
Nov 11, 2024

chore: reset dev ci flags

c6907d9
Select commit
Loading
Failed to load commit list.
Merged

refactor: split out composite electoral system trait #5334

chore: reset dev ci flags
c6907d9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 11, 2024 in 0s

71% (-0%) compared to 9842dea

View this Pull Request on Codecov

71% (-0%) compared to 9842dea

Details

Codecov Report

Attention: Patch coverage is 79.43596% with 175 lines in your changes missing coverage. Please review.

Project coverage is 71%. Comparing base (9842dea) to head (c6907d9).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
...allets/cf-elections/src/electoral_system_runner.rs 13% 40 Missing ⚠️
state-chain/pallets/cf-elections/src/lib.rs 85% 21 Missing and 9 partials ⚠️
...ts/cf-elections/src/electoral_systems/composite.rs 56% 20 Missing and 7 partials ⚠️
...cf-elections/src/electoral_systems/mocks/access.rs 91% 23 Missing ⚠️
...lectoral_systems/blockchain/delta_based_ingress.rs 38% 9 Missing and 1 partial ⚠️
...te-chain/runtime/src/chainflip/solana_elections.rs 90% 2 Missing and 8 partials ⚠️
...ate-chain/pallets/cf-elections/src/benchmarking.rs 57% 6 Missing ⚠️
engine/src/elections.rs 0% 5 Missing ⚠️
...e/src/state_chain_observer/client/electoral_api.rs 0% 5 Missing ⚠️
...chain/pallets/cf-elections/src/electoral_system.rs 0% 1 Missing and 3 partials ⚠️
... and 7 more
Additional details and impacted files 
@@          Coverage Diff           @@
##            main   #5334    +/-   ##
======================================
- Coverage     72%     71%    -0%     
======================================
  Files        486     487     +1     
  Lines      85863   86047   +184     
  Branches   85863   86047   +184     
======================================
- Hits       61515   61435    -80     
- Misses     21533   21689   +156     
- Partials    2815    2923   +108

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov