feat: structured error return types for rpcs #5346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandanlen
requested review from
zoheb391 and
GabrielBuragev
and removed request for
a team
dandanlen
force-pushed
the
feat/structured_api_error_types
branch
from
76b8595 to
47c80a0
Compare
kylezs
approved these changes
Oct 22, 2024
dandanlen
force-pushed
the
feat/structured_api_error_types
branch
2 times, most recently
from
49d491a to
b2d873a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5346 +/- ##
======================================
Coverage 71% 71%
======================================
Files 494 494
Lines 86145 85641 -504
Branches 86145 85641 -504
======================================
- Hits 61161 60963 -198
+ Misses 22248 21931 -317
- Partials 2736 2747 +11 ☔ View full report in Codecov by Sentry. |
dandanlen
force-pushed
the
feat/structured_api_error_types
branch
from
b2d873a to
5c564a2
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
dandanlen
force-pushed
the
feat/structured_api_error_types
branch
from
5c564a2 to
da688e7
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
dandanlen
force-pushed
the
feat/structured_api_error_types
branch
from
da688e7 to
e1ee366
Compare
syan095
added a commit
that referenced
this pull request
Oct 29, 2024
…waps-close-accounts * origin/main: (44 commits) fix: expire all previous epochs (#5279) feat: add/update contract swaps parameters (#5343) chore: add address to solana logging (#5353) fix: ignore dust underflows in order fills rpc (#5352) chore: consistent naming prewitnessed (#5351) feat: engine-runner verifies gpg signature of old dylib when downloaded (#5339) feat: tainted transaction reporting (#5310) bug: change_utxo not always present (#5340) feat: structured error return types for rpcs (#5346) chore: unify dependencies to root cargo.toml (#5333) feat: Submit a slot number alongside nonce (#5297) chore: use node version from `.nvmrc` 📌 (#5336) chore: add engine account_info logging (#5347) chore: replace manual scale encoding for ts-scale (#5335) chore: more consistent params in Broker API (#5342) feat: broker can encode btc smart contract call (#5329) chore: localnet recreate script can use defaults (#5338) feat: witnessing btc smart contract swaps (#5331) feat: Solana CCM fallback (#5316) fix: scale types for pending ceremonies (#5286) ... # Conflicts: # Cargo.lock # state-chain/chains/src/sol/api.rs # state-chain/pallets/cf-broadcast/src/migrations.rs # state-chain/pallets/cf-environment/Cargo.toml
dandanlen
added a commit
that referenced
this pull request
Oct 30, 2024
dandanlen
added a commit
that referenced
this pull request
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
See #5327 for details.