Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: consistent naming prewitnessed #5351

Merged
merged 1 commit into from
Oct 24, 2024
Merged

chore: consistent naming prewitnessed #5351

merged 1 commit into from
Oct 24, 2024

Conversation

kylezs
Copy link
Contributor

@kylezs kylezs commented Oct 24, 2024

Everywhere else we treat "prewitnessed as one word" so making it consistent.

@kylezs kylezs requested a review from dandanlen as a code owner October 24, 2024 13:55
@kylezs kylezs requested a review from Janislav October 24, 2024 13:55
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 71%. Comparing base (dc8bf3e) to head (f608abb).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
state-chain/pallets/cf-ingress-egress/src/lib.rs 50% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #5351    +/-   ##
======================================
- Coverage     71%     71%    -0%     
======================================
  Files        495     495            
  Lines      86335   86199   -136     
  Branches   86335   86199   -136     
======================================
- Hits       61623   61429   -194     
- Misses     21951   22001    +50     
- Partials    2761    2769     +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Janislav Janislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kylezs kylezs added this pull request to the merge queue Oct 24, 2024
Merged via the queue into main with commit d0981f1 Oct 24, 2024
48 of 49 checks passed
@kylezs kylezs deleted the fix/rename-prewitnessed branch October 24, 2024 15:33
syan095 added a commit that referenced this pull request Oct 29, 2024
…waps-close-accounts

* origin/main: (44 commits)
  fix: expire all previous epochs (#5279)
  feat: add/update contract swaps parameters (#5343)
  chore: add address to solana logging (#5353)
  fix: ignore dust underflows in order fills rpc (#5352)
  chore: consistent naming prewitnessed (#5351)
  feat: engine-runner verifies gpg signature of old dylib when downloaded (#5339)
  feat: tainted transaction reporting (#5310)
  bug: change_utxo not always present (#5340)
  feat: structured error return types for rpcs (#5346)
  chore: unify dependencies to root cargo.toml (#5333)
  feat: Submit a slot number alongside nonce (#5297)
  chore: use node version from `.nvmrc` 📌 (#5336)
  chore: add engine account_info logging (#5347)
  chore: replace manual scale encoding for ts-scale (#5335)
  chore: more consistent params in Broker API (#5342)
  feat: broker can encode btc smart contract call (#5329)
  chore: localnet recreate script can use defaults (#5338)
  feat: witnessing btc smart contract swaps (#5331)
  feat: Solana CCM fallback (#5316)
  fix: scale types for pending ceremonies (#5286)
  ...

# Conflicts:
#	Cargo.lock
#	state-chain/chains/src/sol/api.rs
#	state-chain/pallets/cf-broadcast/src/migrations.rs
#	state-chain/pallets/cf-environment/Cargo.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants