Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix submission watcher test #5358

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Conversation

j4m1ef0rd
Copy link
Contributor

Pull Request

Closes: PRO-1718

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have written sufficient tests.
  • I have written and tested required migrations.
  • I have updated documentation where appropriate.

Summary

Changed the jsonrpsee::Subscription into a Stream so we can return an empty stream in the test.

@j4m1ef0rd j4m1ef0rd added the CFE label Oct 25, 2024
@j4m1ef0rd j4m1ef0rd requested a review from msgmaxim October 25, 2024 04:35
@j4m1ef0rd j4m1ef0rd self-assigned this Oct 25, 2024
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 92.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 71%. Comparing base (5baa3dd) to head (2986d80).

Files with missing lines Patch % Lines
...ne/src/state_chain_observer/client/base_rpc_api.rs 0% 4 Missing ⚠️
...t/extrinsic_api/signed/submission_watcher/tests.rs 96% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #5358    +/-   ##
======================================
  Coverage     71%     71%            
======================================
  Files        496     497     +1     
  Lines      86485   86447    -38     
  Branches   86485   86447    -38     
======================================
+ Hits       61751   61802    +51     
+ Misses     21971   21864   -107     
- Partials    2763    2781    +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kylezs kylezs self-requested a review October 25, 2024 05:33
@j4m1ef0rd j4m1ef0rd added this pull request to the merge queue Oct 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 29, 2024
@j4m1ef0rd j4m1ef0rd added this pull request to the merge queue Oct 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 29, 2024
@j4m1ef0rd j4m1ef0rd enabled auto-merge October 30, 2024 00:53
@j4m1ef0rd j4m1ef0rd added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit ce6927f Oct 30, 2024
46 of 48 checks passed
@j4m1ef0rd j4m1ef0rd deleted the test/fix-submission-watcher-test2 branch October 30, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants