fix: request_swap_deposit_address_with_affiliates refund address is consistent with destination address type
#5360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_address WIP: to add unit tests
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5360 +/- ##
======================================
- Coverage 72% 71% -0%
======================================
Files 497 497
Lines 86341 86214 -127
Branches 86341 86214 -127
======================================
- Hits 61740 61568 -172
- Misses 21821 21865 +44
- Partials 2780 2781 +1 ☔ View full report in Codecov by Sentry. |
|
I think the reason this is failing in the bouncer is because the SDK needs to be updated... (I can make sure this is done) |
… refactor/refund-address-type
dandanlen
approved these changes
Oct 30, 2024
dandanlen
changed the title
request_swap_deposit_address_with_affiliates refund address is consistent with destination address typerequest_swap_deposit_address_with_affiliates refund address is consistent with destination address type
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Merge queue is failing due to failed Solana CCM Swaps after runtime migration. Not sure if this is related to this PR as no migration was added. UPdate: just retried to merge and the PR went through. |
syan095
added a commit
that referenced
this pull request
Nov 3, 2024
…d-migration * origin/main: fix: retry with search history enabled after some attempts (#5370) fix: rpc subscription return types (#5374) chore: remove unused stream_utils (#5373) fix: always sweep on RPC free balance (#5376) fix: make boost detection more accurate (#5369) chore: better not contributing error message (#5368) chore: rename ElectoralSystemStatus -> ElectionPalletStatus (#5367) fix: `request_swap_deposit_address_with_affiliates` refund address is consistent with destination address type (#5360) feat: add sol chain tracking metric (#5366) fix: remove is_vote_valid (#5363) fix: separate lp account for lp api (#5354) fix: features for test-externalities (#5365) Update localnet polkadot runtime to v1.3.3 (#5337)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: PRO-1709
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
Make Refund parameter's address to be consistent with the destination_address