Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: expire all previous epochs (#5279)" #5362

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

kylezs
Copy link
Contributor

@kylezs kylezs commented Oct 29, 2024

Pull Request

Checklist

Please conduct a thorough self-review before opening the PR.

Summary

Reason this was causing issues is still be investigated. But CI has passed twice without this commit and has been failing on everything when this commit was included.

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 78.04878% with 18 lines in your changes missing coverage. Please review.

Project coverage is 71%. Comparing base (5baa3dd) to head (7ff7794).

Files with missing lines Patch % Lines
state-chain/custom-rpc/src/lib.rs 0% 11 Missing ⚠️
state-chain/runtime/src/lib.rs 0% 1 Missing and 3 partials ⚠️
state-chain/pallets/cf-validator/src/lib.rs 75% 3 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #5362    +/-   ##
======================================
- Coverage     71%     71%    -0%     
======================================
  Files        496     495     -1     
  Lines      86485   86298   -187     
  Branches   86485   86298   -187     
======================================
- Hits       61751   61515   -236     
- Misses     21971   22020    +49     
  Partials    2763    2763            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kylezs kylezs force-pushed the debug/revert-last-commit branch from 7ff7794 to b724f08 Compare October 29, 2024 10:54
@kylezs kylezs changed the title Debug/revert last commit Revert "fix: expire all previous epochs (#5279)" Oct 29, 2024
@kylezs kylezs marked this pull request as ready for review October 29, 2024 10:55
@kylezs kylezs requested a review from dandanlen as a code owner October 29, 2024 10:55
@dandanlen dandanlen enabled auto-merge October 29, 2024 11:00
@dandanlen dandanlen added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit d4eff08 Oct 29, 2024
47 of 49 checks passed
@dandanlen dandanlen deleted the debug/revert-last-commit branch October 29, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants