Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename ElectoralSystemStatus -> ElectionPalletStatus #5367

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

kylezs
Copy link
Contributor

@kylezs kylezs commented Oct 30, 2024

Pull Request

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have written sufficient tests.
  • I have written and tested required migrations.
  • I have updated documentation where appropriate.

Summary

It's not the ElectoralSystemStatus at all... is a recipe for confusion, so renaming.

@kylezs kylezs requested a review from dandanlen as a code owner October 30, 2024 15:06
@kylezs kylezs marked this pull request as draft October 31, 2024 08:52
@kylezs kylezs force-pushed the chore/rename-election-pallet-status branch from 92ab020 to 0cd1242 Compare October 31, 2024 08:52
@kylezs kylezs marked this pull request as ready for review October 31, 2024 08:52
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71%. Comparing base (7c403b5) to head (0cd1242).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
state-chain/pallets/cf-elections/src/lib.rs 78% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #5367    +/-   ##
======================================
- Coverage     72%     71%    -0%     
======================================
  Files        497     497            
  Lines      86341   86216   -125     
  Branches   86341   86216   -125     
======================================
- Hits       61740   61559   -181     
- Misses     21821   21869    +48     
- Partials    2780    2788     +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dandanlen dandanlen added this pull request to the merge queue Oct 31, 2024
Merged via the queue into main with commit 99bc666 Oct 31, 2024
48 of 49 checks passed
@dandanlen dandanlen deleted the chore/rename-election-pallet-status branch October 31, 2024 11:25
syan095 added a commit that referenced this pull request Nov 3, 2024
…d-migration

* origin/main:
  fix: retry with search history enabled after some attempts (#5370)
  fix: rpc subscription return types (#5374)
  chore: remove unused stream_utils (#5373)
  fix: always sweep on RPC free balance (#5376)
  fix: make boost detection more accurate (#5369)
  chore: better not contributing error message (#5368)
  chore: rename ElectoralSystemStatus -> ElectionPalletStatus (#5367)
  fix: `request_swap_deposit_address_with_affiliates` refund address is consistent with destination address type (#5360)
  feat: add sol chain tracking metric (#5366)
  fix: remove is_vote_valid (#5363)
  fix: separate lp account for lp api (#5354)
  fix: features for test-externalities (#5365)
  Update localnet polkadot runtime to v1.3.3 (#5337)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants