fix: make boost detection more accurate #5369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5369 +/- ##
======================================
- Coverage 72% 71% -0%
======================================
Files 497 497
Lines 86352 86213 -139
Branches 86352 86213 -139
======================================
- Hits 61759 61563 -196
- Misses 21814 21869 +55
- Partials 2779 2781 +2 ☔ View full report in Codecov by Sentry. |
- Proof that we can report between pre and witness still rejecting a tx if the channel was not bossted - We can not change the status of a report if its already prewitnessed
dandanlen
commented
Oct 31, 2024
syan095
added a commit
that referenced
this pull request
Nov 3, 2024
…d-migration * origin/main: fix: retry with search history enabled after some attempts (#5370) fix: rpc subscription return types (#5374) chore: remove unused stream_utils (#5373) fix: always sweep on RPC free balance (#5376) fix: make boost detection more accurate (#5369) chore: better not contributing error message (#5368) chore: rename ElectoralSystemStatus -> ElectionPalletStatus (#5367) fix: `request_swap_deposit_address_with_affiliates` refund address is consistent with destination address type (#5360) feat: add sol chain tracking metric (#5366) fix: remove is_vote_valid (#5363) fix: separate lp account for lp api (#5354) fix: features for test-externalities (#5365) Update localnet polkadot runtime to v1.3.3 (#5337)
dandanlen
added a commit
that referenced
this pull request
Nov 6, 2024
* fix: make boost detection more accurate * fix: remove unnecessary TaintedTransactionStatus::Boosted * test: Added more tests - Proof that we can report between pre and witness still rejecting a tx if the channel was not bossted - We can not change the status of a report if its already prewitnessed * chore: fix cargo fmt * chore: remove dupe test --------- Co-authored-by: Jan Börner <jan@chainflip.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.