fix: rpc subscription return types #5374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandanlen
force-pushed
the
fix/rpc-subscriptions
branch
from
5496635 to
bb89c41
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5374 +/- ##
======================================
- Coverage 72% 71% -0%
======================================
Files 497 497
Lines 86352 86202 -150
Branches 86352 86202 -150
======================================
- Hits 61757 61559 -198
- Misses 21817 21858 +41
- Partials 2778 2785 +7 ☔ View full report in Codecov by Sentry. |
dandanlen
force-pushed
the
fix/rpc-subscriptions
branch
from
2e5dae0 to
85a2689
Compare
kylezs
approved these changes
Nov 1, 2024
syan095
added a commit
that referenced
this pull request
Nov 3, 2024
…d-migration * origin/main: fix: retry with search history enabled after some attempts (#5370) fix: rpc subscription return types (#5374) chore: remove unused stream_utils (#5373) fix: always sweep on RPC free balance (#5376) fix: make boost detection more accurate (#5369) chore: better not contributing error message (#5368) chore: rename ElectoralSystemStatus -> ElectionPalletStatus (#5367) fix: `request_swap_deposit_address_with_affiliates` refund address is consistent with destination address type (#5360) feat: add sol chain tracking metric (#5366) fix: remove is_vote_valid (#5363) fix: separate lp account for lp api (#5354) fix: features for test-externalities (#5365) Update localnet polkadot runtime to v1.3.3 (#5337)
dandanlen
added a commit
that referenced
this pull request
Nov 6, 2024
fix: subscription return types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the return types in rpc subscriptions.
Used to be wrapped in an additional (unexpected) Result.